Skip to content

Commit 5b0df89

Browse files
serhiy-yevtushenkoSerhiy Yevtushenko
andauthored
fix: Address issues with delete_mute_timing (#238)
Co-authored-by: Serhiy Yevtushenko <[email protected]>
1 parent 755ef50 commit 5b0df89

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed

grafana_client/elements/_async/alertingprovisioning.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ async def delete_mute_timing(self, mutetiming_name):
196196
@return:
197197
"""
198198
delete_mute_timing_path = "/v1/provisioning/mute-timings/%s" % mutetiming_name
199-
return await self.client.GET(delete_mute_timing_path)
199+
return await self.client.DELETE(delete_mute_timing_path)
200200

201201
async def get_templates(self):
202202
"""

grafana_client/elements/alertingprovisioning.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ def delete_mute_timing(self, mutetiming_name):
196196
@return:
197197
"""
198198
delete_mute_timing_path = "/v1/provisioning/mute-timings/%s" % mutetiming_name
199-
return self.client.GET(delete_mute_timing_path)
199+
return self.client.DELETE(delete_mute_timing_path)
200200

201201
def get_templates(self):
202202
"""

test/elements/test_alertingprovisioning.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,3 +122,21 @@ def test_delete_notification_policy_tree(self, m):
122122

123123
m.delete("http://localhost/api/v1/provisioning/policies", json=JSON_RESPONSE)
124124
self.grafana.alertingprovisioning.delete_notification_policy_tree()
125+
126+
@requests_mock.Mocker()
127+
def test_delete_mute_timing(self, m):
128+
JSON_RESPONSE = {}
129+
m.delete("http://localhost/api/v1/provisioning/mute-timings/test-mute-timing", json=JSON_RESPONSE)
130+
self.grafana.alertingprovisioning.delete_mute_timing("test-mute-timing")
131+
132+
@requests_mock.Mocker()
133+
def test_get_mute_timing(self, m):
134+
JSON_RESPONSE = {
135+
"name": "test-mute-timing",
136+
"time_intervals": [{}],
137+
"version": "c0764d2988e93f94",
138+
"provenance": "api",
139+
}
140+
m.get("http://localhost/api/v1/provisioning/mute-timings/test-mute-timing", json=JSON_RESPONSE)
141+
response = self.grafana.alertingprovisioning.get_mute_timing("test-mute-timing")
142+
self.assertEqual(response["name"], "test-mute-timing")

0 commit comments

Comments
 (0)