Skip to content

Commit 5d3882d

Browse files
chintalamotl
authored andcommitted
Add support for query parameters on endpoints. Fixes #173 (get_all_folders)
1 parent 513eee4 commit 5d3882d

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

grafana_client/client.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ def _extract_from_response(r, accept_empty_json):
189189
raise
190190

191191
def __getattr__(self, item):
192-
def __request_runner(url, json=None, data=None, headers=None, accept_empty_json=False):
192+
def __request_runner(url, json=None, data=None, params=None, headers=None, accept_empty_json=False):
193193
__url = self._make_url(url)
194194
# Sanity checks.
195195
self._ensure_valid_json_arg(json)
@@ -200,6 +200,7 @@ def __request_runner(url, json=None, data=None, headers=None, accept_empty_json=
200200
__url,
201201
json=json,
202202
data=data,
203+
params=params,
203204
headers=headers,
204205
auth=self.auth,
205206
verify=self.verify,
@@ -244,7 +245,7 @@ def __init__(
244245
self.s.headers.setdefault("Connection", "keep-alive")
245246

246247
def __getattr__(self, item):
247-
async def __request_runner(url, json=None, data=None, headers=None, accept_empty_json=False):
248+
async def __request_runner(url, json=None, data=None, params=None, headers=None, accept_empty_json=False):
248249
__url = self._make_url(url)
249250
# Sanity checks.
250251
self._ensure_valid_json_arg(json)
@@ -255,6 +256,7 @@ async def __request_runner(url, json=None, data=None, headers=None, accept_empty
255256
__url,
256257
json=json,
257258
data=data,
259+
params=params,
258260
headers=headers,
259261
auth=self.auth,
260262
verify=self.verify,

grafana_client/elements/_async/folder.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ async def get_all_folders(self, parent_uid=None):
1212
:return:
1313
"""
1414
path = "/folders"
15-
data = {}
15+
params = {}
1616
if parent_uid:
17-
data["parentUid"] = parent_uid
18-
return await self.client.GET(path, data=data)
17+
params["parentUid"] = parent_uid
18+
return await self.client.GET(path, params=params)
1919

2020
async def get_folder(self, uid):
2121
"""

grafana_client/elements/folder.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ def get_all_folders(self, parent_uid=None):
1212
:return:
1313
"""
1414
path = "/folders"
15-
data = {}
15+
params = {}
1616
if parent_uid:
17-
data["parentUid"] = parent_uid
18-
return self.client.GET(path, data=data)
17+
params["parentUid"] = parent_uid
18+
return self.client.GET(path, params=params)
1919

2020
def get_folder(self, uid):
2121
"""

0 commit comments

Comments
 (0)