Skip to content

Commit c1dc3f7

Browse files
Gilles Hamelamotl
authored andcommitted
FIX API DELETE /api/teams/:teamId/groups?groupId=external-group-id
Fix incorrect API call parameter : It returned always 404.
1 parent b26438f commit c1dc3f7

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

grafana_client/elements/team.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,6 @@ def remove_team_external_group(self, team_id, group_id):
215215
:param group_id:
216216
:return:
217217
"""
218-
team_group_path = "/teams/%s/groups/%s" % (team_id, group_id)
218+
team_group_path = "/teams/%s/groups?groupId=%s" % (team_id, group_id)
219219
r = self.client.DELETE(team_group_path)
220220
return r

test/elements/test_team.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -327,8 +327,8 @@ def test_add_team_external_group(self, m):
327327
@requests_mock.Mocker()
328328
def test_remove_team_external_group(self, m):
329329
m.delete(
330-
"http://localhost/api/teams/42/groups/1",
330+
"http://localhost/api/teams/42/groups?groupId=a_external_group",
331331
json={"message": "Team group removed"},
332332
)
333-
r = self.grafana.teams.remove_team_external_group("42", "1")
333+
r = self.grafana.teams.remove_team_external_group("42", "a_external_group")
334334
self.assertEqual(r["message"], "Team group removed")

0 commit comments

Comments
 (0)