Upgrading grafana to 11.0.0 breaks `smartquery` subsystem

[hbaghar]

Describe the bug
On upgrading my grafana instance to v11.0.0 I can no longer use some scripts I had created to create snapshots of my dashboards. Only thing I have noticed so far is that I can no longer able to make postgresql queries using smartquery

To Reproduce
Steps to reproduce the behavior:

1. Make postgresql query call using smartquery
2. Observe error

  File "/Users/miniconda3/envs/my-env/lib/python3.9/site-packages/grafana_client/elements/datasource.py", line 349, in smartquery
    request = query_factory(datasource, model)
  File "/Users/miniconda3/envs/my-env/lib/python3.9/site-packages/grafana_client/knowledge.py", line 423, in query_factory
    raise NotImplementedError(f"Unknown data source type: {datasource_type}")
NotImplementedError: Unknown data source type: grafana-postgresql-datasource

Expected behavior
Function should return a response with data from my postgresql datasource

Versions

• Grafana: [ 11.0.0]
• grafana-client: [4.1.0 ]
• Authentication: [Token]

Additional context
Unclear at this point if there are more breaking changes. I know that the latest release of this package supports only up to grafana 10.x. I wanted to know if we have any visibility on a newer release for this package that will resolve these issues.

[amotl]

Dear @hbaghar,

thanks a stack for your report. The "smartquery" subsystem is a bit secondary to grafana-client, nevertheless we sure enough would like to see this issue fixed. Have you been able to come up with a solution how to fix this in one way or another?

With kind regards,
Andreas.

[amotl]

Unclear at this point if there are more breaking changes. I know that the latest release of this package supports only up to grafana 10.x. I wanted to know if we have any visibility on a newer release for this package that will resolve these issues.

As far as grafana-wtf covers the grafana-client API, the library should be well compatible with Grafana 11.

• CI: Verify support for Grafana 11 grafana-wtf#140

[amotl]

Dear @hbaghar,

I've just submitted a patch.

• Smartquery: Fix querying PostgreSQL with Grafana 11 #208

Do you think it could help to resolve the problem for you already? I haven't tested it, so I would need your feedback.

With kind regards,
Andreas.

[amotl]

Hi again. The patch has been included into version 4.2.4, but I haven't tested it. Maybe you can report back if it makes a positive difference?

[amotl]

Gentle ping. ;]

[amotl]

Hi @hbaghar. Emulating a little @stalebot, may I humbly ask you to check if this problem has been resolved for you, when using the most recent version of grafana-wtf?

[MatthewMarsee]

Hi, I just had a similar error with the smartquery after updating to Grafana 11 (ERROR: Unknown data source type: grafana-postgresql-datasource) with grafana_client 4.3.1. I solved this by updating line 262 in ~/python3.11/site-packages/grafana_client/knowledge.py

From: elif datasource_type in ("postgres", "mssql", "mysql"):
To: elif datasource_type in ("postgres", "mssql", "mysql","grafana-postgresql-datasource"):

"grafana-postgresql-datasource" is accounted for on line 100, but not later in line 262 when the query is formatted.

[amotl]

I see. So, "fixing the problem" in line 100 per 05ddd1e clearly wasn't enough. Thank you so much!

[amotl]

Hi again. We just submitted GH-218 based on your findings. Thanks!