From 006c30e9b2f00895fa3fffe86ddd5cc4a156ac9e Mon Sep 17 00:00:00 2001 From: Serhiy Yevtushenko Date: Tue, 2 Sep 2025 11:47:34 +0200 Subject: [PATCH 1/3] fix: issues with delete_mute_timing --- grafana_client/elements/_async/alertingprovisioning.py | 2 +- grafana_client/elements/alertingprovisioning.py | 2 +- test/elements/test_alertingprovisioning.py | 6 ++++++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/grafana_client/elements/_async/alertingprovisioning.py b/grafana_client/elements/_async/alertingprovisioning.py index 547741c..46129f9 100644 --- a/grafana_client/elements/_async/alertingprovisioning.py +++ b/grafana_client/elements/_async/alertingprovisioning.py @@ -188,7 +188,7 @@ async def delete_mute_timing(self, mutetiming_name): @return: """ delete_mute_timing_path = "/v1/provisioning/mute-timings/%s" % mutetiming_name - return await self.client.GET(delete_mute_timing_path) + return await self.client.DELETE(delete_mute_timing_path) async def get_templates(self): """ diff --git a/grafana_client/elements/alertingprovisioning.py b/grafana_client/elements/alertingprovisioning.py index 821bd04..3de5155 100644 --- a/grafana_client/elements/alertingprovisioning.py +++ b/grafana_client/elements/alertingprovisioning.py @@ -188,7 +188,7 @@ def delete_mute_timing(self, mutetiming_name): @return: """ delete_mute_timing_path = "/v1/provisioning/mute-timings/%s" % mutetiming_name - return self.client.GET(delete_mute_timing_path) + return self.client.DELETE(delete_mute_timing_path) def get_templates(self): """ diff --git a/test/elements/test_alertingprovisioning.py b/test/elements/test_alertingprovisioning.py index 7d9c6a9..43e3098 100644 --- a/test/elements/test_alertingprovisioning.py +++ b/test/elements/test_alertingprovisioning.py @@ -115,3 +115,9 @@ def test_update_alertrule_disable_provenance(self, m): headers = history[0].headers self.assertIn("X-Disable-Provenance", headers) self.assertEqual(headers["X-Disable-Provenance"], "true") + + @requests_mock.Mocker() + def test_delete_mute_timing(self, m): + JSON_RESPONSE = {} + m.delete("http://localhost/api/v1/provisioning/mute-timing", json=JSON_RESPONSE) + self.grafana.alertingprovisioning.delete_mute_timing("test-mute-timing") From 06045131d1b9e0a1facae612e15991f0a12b91b3 Mon Sep 17 00:00:00 2001 From: Serhiy Yevtushenko Date: Tue, 2 Sep 2025 11:53:00 +0200 Subject: [PATCH 2/3] fix: corrected expected request path in test --- test/elements/test_alertingprovisioning.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/elements/test_alertingprovisioning.py b/test/elements/test_alertingprovisioning.py index 43e3098..25b18e3 100644 --- a/test/elements/test_alertingprovisioning.py +++ b/test/elements/test_alertingprovisioning.py @@ -119,5 +119,5 @@ def test_update_alertrule_disable_provenance(self, m): @requests_mock.Mocker() def test_delete_mute_timing(self, m): JSON_RESPONSE = {} - m.delete("http://localhost/api/v1/provisioning/mute-timing", json=JSON_RESPONSE) + m.delete("http://localhost/api/v1/provisioning/mute-timings/test-mute-timing", json=JSON_RESPONSE) self.grafana.alertingprovisioning.delete_mute_timing("test-mute-timing") From 90d0dab65bb2cf7d8f979b83ceabc81bbd53feef Mon Sep 17 00:00:00 2001 From: Serhiy Yevtushenko Date: Tue, 2 Sep 2025 12:08:00 +0200 Subject: [PATCH 3/3] fix: Added test for get_mute_timing --- test/elements/test_alertingprovisioning.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/test/elements/test_alertingprovisioning.py b/test/elements/test_alertingprovisioning.py index bce8138..55e4d0a 100644 --- a/test/elements/test_alertingprovisioning.py +++ b/test/elements/test_alertingprovisioning.py @@ -128,3 +128,15 @@ def test_delete_mute_timing(self, m): JSON_RESPONSE = {} m.delete("http://localhost/api/v1/provisioning/mute-timings/test-mute-timing", json=JSON_RESPONSE) self.grafana.alertingprovisioning.delete_mute_timing("test-mute-timing") + + @requests_mock.Mocker() + def test_get_mute_timing(self, m): + JSON_RESPONSE = { + "name": "test-mute-timing", + "time_intervals": [{}], + "version": "c0764d2988e93f94", + "provenance": "api", + } + m.get("http://localhost/api/v1/provisioning/mute-timings/test-mute-timing", json=JSON_RESPONSE) + response = self.grafana.alertingprovisioning.get_mute_timing("test-mute-timing") + self.assertEqual(response["name"], "test-mute-timing")