Skip to content

Commit 3592bf9

Browse files
committed
Turn off concurrent downloads by default
As concurrency and caching together is problematic, and might lead to segfaults, turn off concurrent downloads by default.
1 parent 8f8fa6e commit 3592bf9

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

CHANGES.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ grafana-wtf changelog
66
in progress
77
===========
88
- Started using ``versioningit`` for versioning
9+
- As concurrency and caching together is problematic, and might
10+
lead to segfaults, turn off concurrent downloads by default.
11+
Thank you, @glitchwizard.
912

1013
2025-02-04 0.22.0
1114
=================

README.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,11 @@ Watching out for recent editing activity on any dashboards?
250250
# Display 50 most recent changes across all dashboards.
251251
grafana-wtf log --number=50
252252

253+
Concurrency
254+
===========
255+
256+
Use the ``--concurrency`` option, for example ``--concurrency=5``, to enable
257+
concurrent downloading per ``ThreadPoolExecutor``.
253258

254259

255260
********

grafana_wtf/commands.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def run():
5353
--format=<format> Output format. One of textual, tabular, json, yaml.
5454
--cache-ttl=<cache-ttl> Time-to-live for the request cache in seconds. [default: 3600]
5555
--drop-cache Drop cache before requesting resources
56-
--concurrency=<concurrency> Run multiple requests in parallel. [default: 5]
56+
--concurrency=<concurrency> Run multiple requests in parallel. [default: 0]
5757
--dry-run Dry-run mode for the `replace` subcommand.
5858
--verbose Enable verbose mode
5959
--version Show version information

0 commit comments

Comments
 (0)