Skip to content

Commit 22de0cf

Browse files
authored
Remove experimental flag from stage.windowsevent (#4879)
1 parent ea1a478 commit 22de0cf

File tree

3 files changed

+1
-22
lines changed

3 files changed

+1
-22
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ Main (unreleased)
1313
### Features
1414

1515
- A new `mimir.alerts.kubernetes` component which discovers `AlertmanagerConfig` Kubernetes resources and loads them into a Mimir instance. (@ptodev)
16+
- Mark `stage.windowsevent` block in the `loki.process` component as GA. (@kgeckhart)
1617

1718
### Enhancements
1819

internal/component/loki/process/stages/stage.go

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,6 @@ const (
5050
StageTypeWindowsEvent = "windowsevent"
5151
)
5252

53-
// Add stages that are not GA. Stages that are not specified here are considered GA.
54-
var stagesUnstable = map[string]featuregate.Stability{
55-
StageTypeWindowsEvent: featuregate.StabilityExperimental,
56-
}
57-
5853
// Processor takes an existing set of labels, timestamp and log entry and returns either a possibly mutated
5954
// timestamp and log entry
6055
type Processor interface {
@@ -121,14 +116,6 @@ func toStage(p Processor) Stage {
121116
}
122117
}
123118

124-
func checkFeatureStability(stageName string, minStability featuregate.Stability) error {
125-
blockStability, exist := stagesUnstable[stageName]
126-
if exist {
127-
return featuregate.CheckAllowed(blockStability, minStability, fmt.Sprintf("stage %q", stageName))
128-
}
129-
return nil
130-
}
131-
132119
// New creates a new stage for the given type and configuration.
133120
func New(logger log.Logger, jobName *string, cfg StageConfig, registerer prometheus.Registerer, minStability featuregate.Stability) (Stage, error) {
134121
var (
@@ -278,10 +265,6 @@ func New(logger log.Logger, jobName *string, cfg StageConfig, registerer prometh
278265
panic(fmt.Sprintf("unreachable; should have decoded into one of the StageConfig fields: %+v", cfg))
279266
}
280267

281-
if err := checkFeatureStability(s.Name(), minStability); err != nil {
282-
return nil, err
283-
}
284-
285268
return s, nil
286269
}
287270

internal/component/loki/process/stages/windowsevent_test.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,3 @@ func TestWindowsEventValidate(t *testing.T) {
228228
})
229229
}
230230
}
231-
232-
func TestWindowsEventStabilityLevel(t *testing.T) {
233-
_, err := NewPipeline(log.NewNopLogger(), loadConfig(testWindowsEventMsgDefaults), nil, prometheus.DefaultRegisterer, featuregate.StabilityPublicPreview)
234-
require.ErrorContains(t, err, `invalid stage config stage "windowsevent" is at stability level "experimental", which is below the minimum allowed stability level "public-preview". Use --stability.level command-line flag to enable "experimental" features`)
235-
}

0 commit comments

Comments
 (0)