Skip to content

Commit 5f9893e

Browse files
database_observability: log explain plan fetch error at debug (#4935)
In case of sql syntax error, this message is logged repeatedly and there's no actionable outcome. Downgrade to debug level to reduce noise.
1 parent 36babc2 commit 5f9893e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

internal/component/database_observability/mysql/collector/explain_plans.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ func (c *ExplainPlans) Name() string {
457457
}
458458

459459
func (c *ExplainPlans) Start(ctx context.Context) error {
460-
level.Info(c.logger).Log("msg", "collector started")
460+
level.Debug(c.logger).Log("msg", "collector started")
461461

462462
c.running.Store(true)
463463
ctx, cancel := context.WithCancel(ctx)
@@ -585,7 +585,7 @@ func (c *ExplainPlans) fetchExplainPlans(ctx context.Context) error {
585585

586586
byteExplainPlanJSON, err := c.fetchExplainPlanJSON(ctx, *qi)
587587
if err != nil {
588-
level.Error(logger).Log("msg", "failed to fetch explain plan json bytes", "err", err)
588+
level.Debug(logger).Log("msg", "failed to fetch explain plan json bytes", "err", err)
589589
for _, code := range unrecoverableSQLCodes {
590590
if strings.Contains(err.Error(), fmt.Sprintf("Error %s", code)) {
591591
nonRecoverableFailureOccurred = true

internal/component/database_observability/postgres/collector/explain_plan.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ func (c *ExplainPlan) Name() string {
271271
}
272272

273273
func (c *ExplainPlan) Start(ctx context.Context) error {
274-
level.Info(c.logger).Log("msg", "collector started")
274+
level.Debug(c.logger).Log("msg", "collector started")
275275

276276
c.running.Store(true)
277277
ctx, cancel := context.WithCancel(ctx)
@@ -424,7 +424,7 @@ func (c *ExplainPlan) fetchExplainPlans(ctx context.Context) error {
424424

425425
byteExplainPlanJSON, err := c.fetchExplainPlanJSON(ctx, *qi)
426426
if err != nil {
427-
level.Error(logger).Log("msg", "failed to fetch explain plan json bytes", "err", err)
427+
level.Debug(logger).Log("msg", "failed to fetch explain plan json bytes", "err", err)
428428
for _, code := range unrecoverablePostgresSQLErrors {
429429
if strings.Contains(err.Error(), code) {
430430
nonRecoverableFailureOccurred = true

0 commit comments

Comments
 (0)