fix(loki): prevent blocked fanout destination from blocking others issue 2194 #4989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement per-destination buffered queues for loki.process, loki.relabel, and loki.secretfilter components to prevent a slow or blocked downstream receiver from blocking log delivery to other destinations. Key changes: - Each downstream destination gets its own buffered queue with a dedicated worker goroutine, ensuring FIFO ordering while preventing head-of-line blocking - Configurable queue size via max_forward_queue_size (default: 100,000 entries per destination) - Optional block_on_full mode (default: false): - false: drop entries when queue is full (non-blocking) - true: retry with exponential backoff (5ms to 5s max) - New metrics for observability: - *_dropped_entries_total: entries dropped due to full queue - *_enqueue_retries_total: retry attempts when block_on_full=true Fixes: grafana#2194
Add documentation for the new max_forward_queue_size and block_on_full arguments in loki.process, loki.relabel, and loki.secretfilter. Update CHANGELOG.md with the bugfix entry.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement per-destination buffered queues for loki.process, loki.relabel, and loki.secretfilter components to prevent a slow or blocked downstream receiver from blocking log delivery to other destinations.
Key changes:
Each downstream destination gets its own buffered queue with a dedicated worker goroutine, ensuring FIFO ordering while preventing head-of-line blocking
Configurable queue size via max_forward_queue_size (default: 100,000 entries per destination)
Optional block_on_full mode (default: false):
New metrics for observability:
Fixes: #2194
PR Description
Which issue(s) this PR fixes
2194
Notes to the Reviewer
PR Checklist