dbo11y: stop tracking alloy's own queries in pg_stat_activity
#4991
+159
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-code-grafana[bot]](https://avatars.githubusercontent.com/u/7195757?s=60&v=4){kind=small}
internal/component/database_observability/postgres/collector/query_samples.go
Show resolved
Hide resolved
cristiangreco
force-pushed
the
cristian/dbo11y-disable-own-queries-tracking-pg
branch
2 times, most recently
from
2bfa3e8 to
d37df3f
Compare
This PR introduces a change for excluding "own queries" in postgres from `pg_stat_activity`: we need to drop samples (and wait events) for the currently connected user. This new behaviour is enabled by default through the setting `exclude_current_user`, as it's deemed safe / recommended. No changes to be done on `pg_stat_statements` as that is achieved through user permissions update (docs on the website).
cristiangreco
force-pushed
the
cristian/dbo11y-disable-own-queries-tracking-pg
branch
from
d37df3f to
d8a065d
Compare
cristiangreco
requested review from
a team and
clayton-cornell
as code owners
Contributor
|
💻 Deploy preview available (dbo11y: stop tracking alloy's own queries in |
4 tasks
clayton-cornell
added
the
type/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR introduces a change for excluding "own queries" in postgres from
pg_stat_activity: we need to drop samples (and wait events) for the currently connected user. This new behaviour is enabled by default through the settingexclude_current_user, as it's deemed safe / recommended.No changes to be done on
pg_stat_statementsas that is achieved through user permissions update (docs on the website).Which issue(s) this PR fixes
Relates to https://github.com/grafana/grafana-dbo11y-app/issues/1307
Notes to the Reviewer
PR Checklist