Close res.Body (#168)

* fix goroutine leak

Signed-off-by: allenzhli <[email protected]>

* get rid of defer

Signed-off-by: allenzhli <[email protected]>

Author: Allenzhli

pkg/client/alerts.go

@@ -26,14 +26,26 @@ func (r *CortexClient) CreateAlertmanagerConfig(ctx context.Context, cfg string,
 		return err
 	}
 
-	_, err = r.doRequest(alertmanagerAPIPath, "POST", payload)
-	return err
+	res, err := r.doRequest(alertmanagerAPIPath, "POST", payload)
+	if err != nil {
+		return err
+	}
+
+	res.Body.Close()
+
+	return nil
 }
 
 // DeleteAlermanagerConfig deletes the users alertmanagerconfig
 func (r *CortexClient) DeleteAlermanagerConfig(ctx context.Context) error {
-	_, err := r.doRequest(alertmanagerAPIPath, "DELETE", nil)
-	return err
+	res, err := r.doRequest(alertmanagerAPIPath, "DELETE", nil)
+	if err != nil {
+		return err
+	}
+
+	res.Body.Close()
+
+	return nil
 }
 
 // GetAlertmanagerConfig retrieves a rule group

pkg/client/rules.go

@@ -28,7 +28,7 @@ func (r *CortexClient) CreateRuleGroup(ctx context.Context, namespace string, rg
 		return err
 	}
 
-	defer res.Body.Close()
+	res.Body.Close()
 
 	return nil
 }
@@ -39,8 +39,14 @@ func (r *CortexClient) DeleteRuleGroup(ctx context.Context, namespace, groupName
 	escapedGroupName := url.PathEscape(groupName)
 	path := r.apiPath + "/" + escapedNamespace + "/" + escapedGroupName
 
-	_, err := r.doRequest(path, "DELETE", nil)
-	return err
+	res, err := r.doRequest(path, "DELETE", nil)
+	if err != nil {
+		return err
+	}
+
+	res.Body.Close()
+
+	return nil
 }
 
 // GetRuleGroup retrieves a rule group