Commit 3b5cacd
authored
fix: pass explicit docker runtime in acceptance tests (#1160)
## Summary
- Adds optional second argument to `build-lgtm.sh` for explicit runtime
override (e.g. `./build-lgtm.sh latest docker`)
- Acceptance tests now pass `docker` explicitly, because `oats`
hardcodes `docker compose` to orchestrate services
## Problem
On CI runners (Ubuntu 24.04) where both Docker and Podman are installed,
if `build-lgtm.sh` uses Podman but `oats` runs `docker compose`, the
built image is invisible to Docker — causing acceptance test timeouts
(connection refused).
This is currently not an issue on `main` (Docker-first preference), but
becomes one when #1158 lands (Podman-first preference). This PR makes
the acceptance tests resilient regardless of the default preference
order.
## Test plan
- [ ] CI acceptance tests pass on this branch
- [ ] `./build-lgtm.sh latest` still auto-detects (no regression)
- [ ] `./build-lgtm.sh latest docker` forces Docker
- [ ] `./build-lgtm.sh latest podman` forces Podman1 parent a389166 commit 3b5cacd
2 files changed
+13
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
| 12 | + | |
12 | 13 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
9 | | - | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
10 | 19 | | |
11 | 20 | | |
12 | 21 | | |
| |||
15 | 24 | | |
16 | 25 | | |
17 | 26 | | |
18 | | - | |
| 27 | + | |
0 commit comments