chore: add alternate "rate limit exceeded" error handling (#494)

The existing handling with the message "API rate limit exceeded..."
catches some errors, but we're now seeing errors like "API rate limit
already exceeded...", which are causing SLO warnings.

Author: njvrzm

pkg/github/client/errorsourcehandling.go

@@ -20,6 +20,7 @@ var (
 		"Resource protected by organization SAML enforcement",
 		"Resource not accessible by personal access token",
 		"API rate limit exceeded",
+		"API rate limit already exceeded",
 		"Resource not accessible by integration", // issue with incorrectly set permissions for token/app
 	}
 )

pkg/github/client/errorsourcehandling_test.go

@@ -81,6 +81,12 @@ func TestAddErrorSourceToError(t *testing.T) {
 			resp:     nil,
 			expected: backend.DownstreamError(errors.New("API rate limit exceeded for ID 1")),
 		},
+		{
+			name:     "limit exceeded error message",
+			err:      errors.New("API rate limit already exceeded for ID 2"),
+			resp:     nil,
+			expected: backend.DownstreamError(errors.New("API rate limit already exceeded for ID 2")),
+		},
 		{
 			name:     "permission error message",
 			err:      errors.New("Resource not accessible by integration"),

pkg/github/testdata/stargazers.golden.jsonc

@@ -9,15 +9,15 @@
 //  }
 //  Name: stargazers
 //  Dimensions: 8 Fields by 3 Rows
-//  +-------------------------------+------------------+----------------+----------------+----------------+----------------+----------------------------+---------------------------------------------+
-//  | Name: starred_at              | Name: star_count | Name: id       | Name: login    | Name: git_name | Name: company  | Name: email                | Name: url                                   |
-//  | Labels:                       | Labels:          | Labels:        | Labels:        | Labels:        | Labels:        | Labels:                    | Labels:                                     |
-//  | Type: []time.Time             | Type: []int64    | Type: []string | Type: []string | Type: []string | Type: []string | Type: []string             | Type: []string                              |
-//  +-------------------------------+------------------+----------------+----------------+----------------+----------------+----------------------------+---------------------------------------------+
-//  | 2023-01-14 10:21:41 +0000 GMT | 3                | NEVER          | gonna          | Run            | Around         | [email protected] | https://www.youtube.com/watch?v=dQw4w9WgXcQ |
-//  | 2023-01-14 10:23:41 +0000 GMT | 2                | NEVER          | gonna          | Let            | You            | [email protected]           |                                             |
-//  | 2023-01-14 10:25:41 +0000 GMT | 1                | NEVER          | gonna          | Give           | You            | [email protected]             |                                             |
-//  +-------------------------------+------------------+----------------+----------------+----------------+----------------+----------------------------+---------------------------------------------+
+//  +---------------------------------+------------------+----------------+----------------+----------------+----------------+----------------------------+---------------------------------------------+
+//  | Name: starred_at                | Name: star_count | Name: id       | Name: login    | Name: git_name | Name: company  | Name: email                | Name: url                                   |
+//  | Labels:                         | Labels:          | Labels:        | Labels:        | Labels:        | Labels:        | Labels:                    | Labels:                                     |
+//  | Type: []time.Time               | Type: []int64    | Type: []string | Type: []string | Type: []string | Type: []string | Type: []string             | Type: []string                              |
+//  +---------------------------------+------------------+----------------+----------------+----------------+----------------+----------------------------+---------------------------------------------+
+//  | 2023-01-14 10:21:41 +0000 +0000 | 3                | NEVER          | gonna          | Run            | Around         | [email protected] | https://www.youtube.com/watch?v=dQw4w9WgXcQ |
+//  | 2023-01-14 10:23:41 +0000 +0000 | 2                | NEVER          | gonna          | Let            | You            | [email protected]           |                                             |
+//  | 2023-01-14 10:25:41 +0000 +0000 | 1                | NEVER          | gonna          | Give           | You            | [email protected]             |                                             |
+//  +---------------------------------+------------------+----------------+----------------+----------------+----------------+----------------------------+---------------------------------------------+
 //  
 //  
 //  🌟 This was machine generated.  Do not edit. 🌟