Skip to content

Commit 9eec011

Browse files
authored
Chore: associate label with input element and update applySQLTemplateVariables type (#88)
* Chore: update applySQLTemplateVariables type to extend SQLQuery * associate label with input for ResourceSelector * keep id
1 parent b466731 commit 9eec011

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/sql/ResourceSelector.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ export function ResourceSelector(props: ResourceSelectorProps) {
121121
<Select
122122
{...props}
123123
id={props.id}
124+
inputId={props.id}
124125
aria-label={props.label}
125126
options={options}
126127
onChange={onChange}
@@ -141,6 +142,7 @@ export function ResourceSelector(props: ResourceSelectorProps) {
141142
<Select
142143
{...props}
143144
id={props.id}
145+
inputId={props.id}
144146
aria-label={props.label}
145147
options={options}
146148
onChange={onChange}

src/sql/utils/utils.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ export function filterSQLQuery(query: SQLQuery): boolean {
99
return !!query.rawSQL;
1010
}
1111

12-
export function applySQLTemplateVariables(
13-
query: SQLQuery,
12+
export function applySQLTemplateVariables<T extends SQLQuery>(
13+
query: T,
1414
scopedVars: ScopedVars,
1515
getTemplateSrv: () => any
16-
): SQLQuery {
16+
): T {
1717
const templateSrv = getTemplateSrv();
1818
return {
1919
...query,

0 commit comments

Comments
 (0)