Add --disable-gpu in the default Chromium args (#262)

Author: AgnesToulet

default.json

@@ -19,9 +19,7 @@
   },
   "rendering": {
     "chromeBin": null,
-    "args": [
-      "--no-sandbox"
-    ],
+    "args": ["--no-sandbox", "--disable-gpu"],
     "ignoresHttpsErrors": false,
 
     "timezone": null,
@@ -42,4 +40,4 @@
     "verboseLogging": false,
     "dumpio": false
   }
-}
+}

dev.json

@@ -19,10 +19,7 @@
   },
   "rendering": {
     "chromeBin": null,
-    "args": [
-      "--no-sandbox",
-      "--disable-setuid-sandbox"
-    ],
+    "args": ["--no-sandbox", "--disable-setuid-sandbox", "--disable-gpu"],
     "ignoresHttpsErrors": false,
 
     "timezone": null,
@@ -43,4 +40,4 @@
     "verboseLogging": false,
     "dumpio": true
   }
-}
+}

devenv/docker/ha/config.json

@@ -10,6 +10,7 @@
   "rendering": {
     "timezone": null,
     "chromeBin": null,
+    "args": ["--no-sandbox", "--disable-gpu"],
     "ignoresHttpsErrors": false,
     "timingMetrics": true,
     "mode": "default",
@@ -18,4 +19,4 @@
       "maxConcurrency": 5
     }
   }
-}
+}

docs/remote_rendering_using_docker.md

@@ -78,7 +78,7 @@ RENDERING_DUMPIO=true
 
 **Start browser with additional arguments:**
 
-Additional arguments to pass to the headless browser instance. Default is `--no-sandbox`. The list of Chromium flags can be found [here](https://peter.sh/experiments/chromium-command-line-switches/). Multiple arguments is separated with comma-character.
+Additional arguments to pass to the headless browser instance. Defaults are `--no-sandbox,--disable-gpu`. The list of Chromium flags can be found [here](https://peter.sh/experiments/chromium-command-line-switches/) and the list of flags used as defaults by Puppeteer can be found [there](https://github.com/puppeteer/puppeteer/blob/main/src/node/Launcher.ts#L172). Multiple arguments is separated with comma-character. 
 
 ```bash
 RENDERING_ARGS=--no-sandbox,--disable-setuid-sandbox,--disable-dev-shm-usage,--disable-accelerated-2d-canvas,--disable-gpu,--window-size=1280x758

src/browser/index.ts

@@ -15,6 +15,12 @@ export function createBrowser(config: RenderingConfig, log: Logger): Browser {
     return new ReusableBrowser(config, log);
   }
 
+  if (!config.args.includes['--disable-gpu']) {
+    log.warn(
+      'using default mode without the --disable-gpu flag is not recommended as it can cause Puppeteer newPage function to freeze, leaving browsers open'
+    );
+  }
+
   return new Browser(config, log);
 }
 

src/config.ts

@@ -62,7 +62,7 @@ export interface PluginConfig {
 
 const defaultRenderingConfig: RenderingConfig = {
   chromeBin: undefined,
-  args: ['--no-sandbox'],
+  args: ['--no-sandbox', '--disable-gpu'],
   ignoresHttpsErrors: false,
   timezone: undefined,
   acceptLanguage: undefined,