Use timeout opt value for browser page.goto (#171)

w4rgrum · hhars · web-flow · commit 311abc0b643d · 2021-01-26T21:46:27.000+01:00
Co-authored-by: hhars &lt;hugo.hars@amadeus.com&gt;
diff --git a/src/browser/browser.ts b/src/browser/browser.ts
@@ -175,7 +175,7 @@ export class Browser {
       this.log.debug('Navigating and waiting for all network requests to finish', 'url', options.url);
     }
 
-    await page.goto(options.url, { waitUntil: 'networkidle0' });
+    await page.goto(options.url, { waitUntil: 'networkidle0', timeout: options.timeout * 1000 });
 
     if (this.config.verboseLogging) {
       this.log.debug('Waiting for dashboard/panel to load', 'timeout', `${options.timeout}s`);

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ export class Browser {`
`175`	`175`	`this.log.debug('Navigating and waiting for all network requests to finish', 'url', options.url);`
`176`	`176`	`}`
`177`	`177`
`178`		`- await page.goto(options.url, { waitUntil: 'networkidle0' });`
	`178`	`+ await page.goto(options.url, { waitUntil: 'networkidle0', timeout: options.timeout * 1000 });`
`179`	`179`
`180`	`180`	`if (this.config.verboseLogging) {`
`181`	`181`	this.log.debug('Waiting for dashboard/panel to load', 'timeout', `${options.timeout}s`);