Skip to content

Commit 5fd62af

Browse files
authored
Browser: Fix panel rendered waiting condition (#472)
1 parent 473f004 commit 5fd62af

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/browser/browser.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export class Browser {
4747
}
4848
}
4949

50-
async start(): Promise<void> {}
50+
async start(): Promise<void> { }
5151

5252
validateRenderOptions(options: RenderOptions) {
5353
if (options.url.startsWith(`socket://`)) {
@@ -216,7 +216,7 @@ export class Browser {
216216
heights.dashboard.client,
217217
scrollDivSelector
218218
);
219-
219+
220220
await new Promise(executor => setTimeout(executor, scrollDelay));
221221
}
222222

@@ -351,8 +351,8 @@ export class Browser {
351351
return totalPanelsRendered >= panelCount;
352352
}
353353

354-
const panelCount = document.querySelectorAll('.panel').length || document.querySelectorAll('.panel-container').length;
355-
return (window as any).panelsRendered >= panelCount || (window as any).panelsRendered === undefined;
354+
const panelCount = document.querySelectorAll('.panel-solo').length || document.querySelectorAll('[class$=\'panel-container\']').length;
355+
return (window as any).panelsRendered >= panelCount || panelCount === 0
356356
},
357357
{
358358
timeout: options.timeout * 1000,
@@ -533,7 +533,7 @@ export class Browser {
533533

534534
const loc = msg.location();
535535
if (msgType === 'error' && msg.text() !== 'JSHandle@object') {
536-
this.log.error('Browser console error', 'msg', msg.text(), 'url', loc.url, 'line', loc.lineNumber, 'column', loc.columnNumber);
536+
this.log.error('Browser console error', 'msg', msg.text(), 'url', loc.url, 'line', loc.lineNumber, 'column', loc.columnNumber);
537537
return;
538538
}
539539

0 commit comments

Comments
 (0)