Chore: Upgrade to Node 18 (#448)

* Update dependencies

* Update docker iamges

* Use the latest CI image

* Sign & lint .drone.yml

* Add .nvmrc

* Update plugin-ci image

* Update drone

* update node version

* Fix security scanning step

* Install zip in package step

---------

Co-authored-by: Joan López de la Franca Beltran <[email protected]>
Co-authored-by: Andreas Christou <[email protected]>

Author: 3 people

.drone.yml

@@ -0,0 +1 @@
+18.13.0

.nvmrc

@@ -1,4 +1,4 @@
-FROM node:16-alpine AS base
+FROM node:18-alpine AS base
 
 ENV CHROME_BIN="/usr/bin/chromium-browser"
 ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD="true"

Dockerfile

@@ -1,4 +1,4 @@
-FROM node:16-slim AS base
+FROM node:18-slim AS base
 
 ENV CHROME_BIN="/usr/bin/google-chrome-stable"
 ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD="true"

debian.Dockerfile

@@ -44,7 +44,7 @@
     "winston": "^3.8.2"
   },
   "devDependencies": {
-    "@grafana/eslint-config": "5.0.0",
+    "@grafana/eslint-config": "^6.0.0",
     "@types/dompurify": "2.3.4",
     "@types/express": "^4.17.14",
     "@types/jsdom": "20.0.0",
@@ -56,7 +56,7 @@
     "cross-env": "7.0.3",
     "eslint": "8.23.1",
     "eslint-config-prettier": "8.5.0",
-    "eslint-plugin-jsdoc": "39.3.6",
+    "eslint-plugin-jsdoc": "^46.5.0",
     "eslint-plugin-prettier": "4.2.1",
     "eslint-plugin-react": "7.31.8",
     "eslint-plugin-react-hooks": "4.6.0",
@@ -81,6 +81,6 @@
   },
   "bin": "build/app.js",
   "engines": {
-    "node": ">= 16"
+    "node": ">= 18"
   }
 }

package.json

@@ -9,5 +9,6 @@ fi
 
 OUT="${2:-plugin-${ARCH}}"
 
+apt-get update && apt-get install zip -y
 mkdir -p artifacts
-(cd dist && zip -yqr ../artifacts/${OUT}.zip ${OUT})
+(cd dist && zip -yqr ../artifacts/${OUT}.zip ${OUT})

scripts/archive_target.sh

@@ -1,14 +1,12 @@
 load('scripts/drone/utils.star', 'ci_image')
-load('scripts/drone/grabpl.star', 'download_grabpl_step')
-load('scripts/drone/promotion.star', 'publish_to_docker')
-load('scripts/drone/utils.star', 'pipeline')
 load('scripts/drone/vault.star', 'from_secret')
 
 def install_deps_step():
     return {
         'name': 'yarn-install',
         'image': ci_image,
         'commands': [
+            '. ~/.init-nvm.sh',
             'yarn install --frozen-lockfile --no-progress',
         ],
         'depends_on': [
@@ -21,6 +19,7 @@ def build_step():
         'name': 'yarn-build',
         'image': ci_image,
         'commands': [
+            '. ~/.init-nvm.sh',
             'yarn build',
         ],
         'depends_on': [
@@ -50,6 +49,7 @@ def package_step(arch, name='', skip_chromium=False, override_output='', skip_er
         'name': name,
         'image': ci_image,
         'commands': [
+            '. ~/.init-nvm.sh',
             pkg_cmd,
             bpm_cmd,
             arc_cmd,
@@ -67,8 +67,8 @@ def security_scan_step():
         'name': 'security-scan',
         'image': ci_image,
         'commands': [
+            '. ~/.init-nvm.sh',
             'echo "Starting veracode scan..."',
-            'apk add curl',
             '# Increase heap size or the scanner will die.',
             'export _JAVA_OPTIONS=-Xmx4g',
             'mkdir -p ci/jobs/security_scan',

scripts/drone/common.star

@@ -1,4 +1,4 @@
-load('scripts/drone/utils.star', 'docker_image', 'ci_image', 'publisher_image')
+load('scripts/drone/utils.star', 'docker_image', 'ci_image')
 load('scripts/drone/vault.star', 'from_secret')
 
 def publish_gh_release():
@@ -49,6 +49,7 @@ def publish_to_gcom():
         'name': 'publish_to_gcom',
         'image': ci_image,
         'commands': [
+            '. ~/.init-nvm.sh',
             'yarn run create-gcom-plugin-json ${DRONE_COMMIT}',
             'sh scripts/push-to-gcom.sh',
         ],

scripts/drone/promotion.star

@@ -1,6 +1,6 @@
 load('scripts/drone/vault.star', 'pull_secret')
 
-ci_image = 'grafana/grafana-plugin-ci:1.6.1-alpine'
+ci_image = 'grafana/grafana-plugin-ci:1.9.0'
 docker_image = 'grafana/grafana-image-renderer'
 publisher_image = 'grafana/integration-grafana-publisher:v9'
 

scripts/drone/utils.star

@@ -31,6 +31,6 @@ if(platform === 'macos' && (arch.includes('arm'))) {
 const outputPath = "dist/" + (process.argv[3] || `plugin-${archArg}`);
 const outputNodeModules = `${outputPath}/node_modules`
 
-childProcess.execSync(`"./node_modules/.bin/pkg" -t node16-${platform}-${arch} . --out-path ${outputPath} --no-native-build`, {stdio: 'inherit'});
+childProcess.execSync(`"./node_modules/.bin/pkg" -t node18-${platform}-${arch} . --out-path ${outputPath} --no-native-build`, {stdio: 'inherit'});
 
 childProcess.execSync(`rm -rf ${outputNodeModules}`)