Skip to content

Commit cea4f8c

Browse files
authored
Update deprecated functions (#375)
1 parent c506856 commit cea4f8c

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

src/browser/browser.ts

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,8 @@ export class Browser {
216216
heights.dashboard.client,
217217
scrollDivSelector
218218
);
219-
await page.waitForTimeout(scrollDelay);
219+
220+
await new Promise(executor => setTimeout(executor, scrollDelay));
220221
}
221222

222223
await page.evaluate((scrollDivSelector) => {
@@ -481,7 +482,7 @@ export class Browser {
481482
}
482483
}
483484

484-
addPageListeners(page: any) {
485+
addPageListeners(page: puppeteer.Page) {
485486
page.on('error', this.logError);
486487
page.on('pageerror', this.logPageError);
487488
page.on('requestfailed', this.logRequestFailed);
@@ -494,16 +495,16 @@ export class Browser {
494495
}
495496
}
496497

497-
removePageListeners(page: any) {
498-
page.removeListener('error', this.logError);
499-
page.removeListener('pageerror', this.logPageError);
500-
page.removeListener('requestfailed', this.logRequestFailed);
501-
page.removeListener('console', this.logConsoleMessage);
498+
removePageListeners(page: puppeteer.Page) {
499+
page.off('error', this.logError);
500+
page.off('pageerror', this.logPageError);
501+
page.off('requestfailed', this.logRequestFailed);
502+
page.off('console', this.logConsoleMessage);
502503

503504
if (this.config.verboseLogging) {
504-
page.removeListener('request', this.logRequest);
505-
page.removeListener('requestfinished', this.logRequestFinished);
506-
page.removeListener('close', this.logPageClosed);
505+
page.off('request', this.logRequest);
506+
page.off('requestfinished', this.logRequestFinished);
507+
page.off('close', this.logPageClosed);
507508
}
508509
}
509510

0 commit comments

Comments
 (0)