Address some AoT warnings (#356)

Author: martincostello

Directory.Build.props

@@ -9,6 +9,7 @@
     <Deterministic>true</Deterministic>
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
+    <LangVersion>latest</LangVersion>
     <NeutralLanguage>en-US</NeutralLanguage>
     <!-- Disable warning about stable packages depending on prerelease packages until all OpenTelemetry dependencies are stable -->
     <NoWarn>$(NoWarn);NU5104</NoWarn>

src/Grafana.OpenTelemetry.Base/ExporterSettings/GrafanaCloudConfigurationHelper.cs

@@ -10,7 +10,7 @@ namespace Grafana.OpenTelemetry
     /// <summary>
     /// Helper class for Grafana Cloud configuration.
     /// </summary>
-    internal class GrafanaCloudConfigurationHelper
+    internal sealed class GrafanaCloudConfigurationHelper
     {
         private const string PathExtensionTraces = "/v1/traces";
         private const string PathExtensionMetrics = "/v1/metrics";

src/Grafana.OpenTelemetry.Base/Grafana.OpenTelemetry.Base.csproj

@@ -47,4 +47,9 @@
     </AssemblyAttribute>
   </ItemGroup>
 
+  <!-- Not supported due to extensive use of reflection https://github.com/grafana/grafana-opentelemetry-dotnet/issues/97 -->
+  <PropertyGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">
+    <IsAotCompatible>false</IsAotCompatible>
+  </PropertyGroup>
+
 </Project>

src/Grafana.OpenTelemetry.Base/GrafanaOpenTelemetryResourceDetector.cs

@@ -9,7 +9,7 @@
 
 namespace Grafana.OpenTelemetry
 {
-    internal class GrafanaOpenTelemetryResourceDetector : IResourceDetector
+    internal sealed class GrafanaOpenTelemetryResourceDetector : IResourceDetector
     {
         internal const string ResourceKey_DistroName = "telemetry.distro.name";
         internal const string ResourceKey_DistroVersion = "telemetry.distro.version";
@@ -25,12 +25,12 @@ public GrafanaOpenTelemetryResourceDetector(GrafanaOpenTelemetrySettings setting
 
         public Resource Detect()
         {
-            var attributes = new List<KeyValuePair<string, object>>(new KeyValuePair<string, object>[]
-            {
+            var attributes = new List<KeyValuePair<string, object>>(
+            [
                 new KeyValuePair<string, object>(ResourceKey_DistroName, ResourceValue_DistroName),
                 new KeyValuePair<string, object>(ResourceKey_DistroVersion, GetDistroVersion()),
                 new KeyValuePair<string, object>(ResourceKey_DeploymentEnvironment, _settings.DeploymentEnvironment)
-            });
+            ]);
 
             attributes.AddRange(_settings.ResourceAttributes);
 

src/Grafana.OpenTelemetry.Base/GrafanaOpenTelemetrySettings.cs

@@ -119,7 +119,7 @@ internal GrafanaOpenTelemetrySettings(IConfiguration configuration)
             Instrumentations.Remove(Instrumentation.AWSLambda);
 
             var disableInstrumentations = configuration[DisableInstrumentationsEnvVarName];
-            char[] separators = new char[] { ',', ':' };
+            char[] separators = [',', ':'];
 
             if (!string.IsNullOrEmpty(disableInstrumentations))
             {

src/Grafana.OpenTelemetry.Base/Instrumentations/AWSInitializer.cs

@@ -7,7 +7,7 @@
 
 namespace Grafana.OpenTelemetry
 {
-    internal class AWSInitializer : InstrumentationInitializer
+    internal sealed class AWSInitializer : InstrumentationInitializer
     {
         public override Instrumentation Id { get; } = Instrumentation.AWS;
 
@@ -17,7 +17,7 @@ protected override void InitializeTracing(TracerProviderBuilder builder)
                 "OpenTelemetry.Instrumentation.AWS",
                 "OpenTelemetry.Trace.TracerProviderBuilderExtensions",
                 "AddAWSInstrumentation",
-                new object[] { builder });
+                [builder]);
         }
     }
 }

src/Grafana.OpenTelemetry.Base/Instrumentations/AWSLambdaInitializer.cs

@@ -7,7 +7,7 @@
 
 namespace Grafana.OpenTelemetry
 {
-    internal class AWSLambdaInitializer : InstrumentationInitializer
+    internal sealed class AWSLambdaInitializer : InstrumentationInitializer
     {
         public override Instrumentation Id { get; } = Instrumentation.AWSLambda;
 
@@ -17,7 +17,7 @@ protected override void InitializeTracing(TracerProviderBuilder builder)
                 "OpenTelemetry.Instrumentation.AWSLambda",
                 "OpenTelemetry.Instrumentation.AWSLambda.TracerProviderBuilderExtensions",
                 "AddAWSLambdaConfigurations",
-                new object[] { builder });
+                [builder]);
         }
     }
 }

src/Grafana.OpenTelemetry.Base/Instrumentations/AspNetCoreInitializer.cs

@@ -8,7 +8,7 @@
 
 namespace Grafana.OpenTelemetry
 {
-    internal class AspNetCoreInitializer : InstrumentationInitializer
+    internal sealed class AspNetCoreInitializer : InstrumentationInitializer
     {
         public override Instrumentation Id { get; } = Instrumentation.AspNetCore;
 
@@ -18,7 +18,7 @@ protected override void InitializeTracing(TracerProviderBuilder builder)
                 "OpenTelemetry.Instrumentation.AspNetCore",
                 "OpenTelemetry.Trace.AspNetCoreInstrumentationTracerProviderBuilderExtensions",
                 "AddAspNetCoreInstrumentation",
-                new object[] { builder });
+                [builder]);
         }
 
         protected override void InitializeMetrics(MeterProviderBuilder builder)
@@ -27,7 +27,7 @@ protected override void InitializeMetrics(MeterProviderBuilder builder)
                 "OpenTelemetry.Instrumentation.AspNetCore",
                 "OpenTelemetry.Metrics.AspNetCoreInstrumentationMeterProviderBuilderExtensions",
                 "AddAspNetCoreInstrumentation",
-                new object[] { builder });
+                [builder]);
         }
     }
 }

src/Grafana.OpenTelemetry.Base/Instrumentations/AspNetInitializer.cs

@@ -8,7 +8,7 @@
 
 namespace Grafana.OpenTelemetry
 {
-    internal class AspNetInitializer : InstrumentationInitializer
+    internal sealed class AspNetInitializer : InstrumentationInitializer
     {
         public override Instrumentation Id { get; } = Instrumentation.AspNet;
 
@@ -18,7 +18,7 @@ protected override void InitializeTracing(TracerProviderBuilder builder)
                 "OpenTelemetry.Instrumentation.AspNet",
                 "OpenTelemetry.Trace.TracerProviderBuilderExtensions",
                 "AddAspNetInstrumentation",
-                new object[] { builder });
+                [builder]);
         }
 
         protected override void InitializeMetrics(MeterProviderBuilder builder)
@@ -27,7 +27,7 @@ protected override void InitializeMetrics(MeterProviderBuilder builder)
                 "OpenTelemetry.Instrumentation.AspNet",
                 "OpenTelemetry.Metrics.MeterProviderBuilderExtensions",
                 "AddAspNetInstrumentation",
-                new object[] { builder });
+                [builder]);
         }
     }
 }

src/Grafana.OpenTelemetry.Base/Instrumentations/CassandraInitializer.cs

@@ -8,7 +8,7 @@
 
 namespace Grafana.OpenTelemetry
 {
-    internal class CassandraInitializer : InstrumentationInitializer
+    internal sealed class CassandraInitializer : InstrumentationInitializer
     {
         public override Instrumentation Id { get; } = Instrumentation.Cassandra;
 
@@ -18,7 +18,7 @@ protected override void InitializeMetrics(MeterProviderBuilder builder)
                 "OpenTelemetry.Instrumentation.Cassandra",
                 "OpenTelemetry.Metrics.MeterProviderBuilderExtensions",
                 "AddCassandraInstrumentation",
-                new object[] { builder });
+                [builder]);
         }
 
         protected override void InitializeTracing(TracerProviderBuilder builder)