Skip to content

Commit b32f25c

Browse files
Use built-in dotnet format
- Use the built-in version of `dotnet format` that understands primary constructors. - Move `csharp_style_namespace_declarations` to suggestion so it doesn't force adoption right now. - Remove redundant `using` statements.
1 parent afafdee commit b32f25c

14 files changed

+2
-19
lines changed

.editorconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ csharp_style_prefer_index_operator = false:none
107107
csharp_style_prefer_range_operator = false:none
108108
csharp_style_pattern_local_over_anonymous_function = true:suggestion
109109
csharp_style_deconstructed_variable_declaration = true:suggestion
110-
csharp_style_namespace_declarations = file_scoped:warning
110+
csharp_style_namespace_declarations = file_scoped:suggestion
111111

112112
# Space preferences
113113
csharp_space_after_cast = false

.github/workflows/dotnet-format.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,5 @@ jobs:
2323
with:
2424
persist-credentials: false
2525

26-
- name: Install format tool
27-
run: dotnet tool install -g dotnet-format
28-
2926
- name: dotnet format
30-
run: dotnet-format --folder --check
27+
run: dotnet format --verify-no-changes

src/Grafana.OpenTelemetry.Base/ExporterSettings/OtlpExporter.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
//
55

66
using System;
7-
using Microsoft.Extensions.Configuration;
87
using OpenTelemetry.Exporter;
98
using OpenTelemetry.Logs;
109
using OpenTelemetry.Metrics;

src/Grafana.OpenTelemetry.Base/GrafanaOpenTelemetryResourceDetector.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@
33
// SPDX-License-Identifier: Apache-2.0
44
//
55

6-
using System;
76
using System.Collections.Generic;
8-
using System.Diagnostics;
97
using System.Reflection;
108
using OpenTelemetry.Resources;
119

src/Grafana.OpenTelemetry.Base/GrafanaOpenTelemetrySettings.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
using System;
77
using System.Collections.Generic;
8-
using System.Linq;
98
using System.Reflection;
109
using Microsoft.Extensions.Configuration;
1110

src/Grafana.OpenTelemetry.Base/Instrumentations/OwinInitializer.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// SPDX-License-Identifier: Apache-2.0
44
//
55

6-
using System;
76
using OpenTelemetry.Trace;
87

98
namespace Grafana.OpenTelemetry

src/Grafana.OpenTelemetry.Base/ReflectionHelper.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// SPDX-License-Identifier: Apache-2.0
44
//
55

6-
using System;
76
using System.Linq;
87
using System.Reflection;
98

tests/Grafana.OpenTelemetry.Tests/GrafanaCloudConfigurationHelperTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
//
55

66
using System;
7-
using Grafana.OpenTelemetry;
87
using Xunit;
98

109
namespace Grafana.OpenTelemetry.Tests

tests/Grafana.OpenTelemetry.Tests/GrafanaOpenTelemetrySettingsTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
using System;
77
using System.Collections.Generic;
88
using System.Reflection;
9-
using Grafana.OpenTelemetry;
109
using Xunit;
1110

1211
namespace Grafana.OpenTelemetry.Tests

tests/Grafana.OpenTelemetry.Tests/InMemoryResourceExporter.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
using System;
77
using System.Collections.Generic;
88
using OpenTelemetry;
9-
using OpenTelemetry.Exporter;
109
using OpenTelemetry.Resources;
1110

1211
namespace Grafana.OpenTelemetry.Tests

0 commit comments

Comments
 (0)