chore(controllers): simplify tests around conditions (#2136)

* feat(controllers): add helper for conditions equality

* chore(controllers): simplify tests for folder controller

* chore(controllers): simplify notification template tests

* chore(controllers): simplify contactpoint tests

* chore(controllers): simplify alertrulegroup tests

* chore(controllers): simplify dashboard tests

* chore(controllers): simplify some datasource tests

* chore(controllers): simplify datasource tests

* chore(controllers): simplify grafana tests

* chore(controllers): simplify library panel tests

* chore(controllers): simplify mute timing

* chore(controllers): simplify notification policy tests

* chore(controllers): simplify LoopDetected test

* feat(CommonResource): expose Metadata

* feat(controllers): add GrafanaCommonReconciler interface

* feat(controllers): add reconcileAndValidateCondition helper

* chore(controllers): switch to reconcileAndValidateCondition

* fix(lint): formatting

Author: weisdd

api/v1beta1/common.go

@@ -54,6 +54,7 @@ type CommonResource interface {
 	client.Object
 	MatchLabels() *metav1.LabelSelector
 	MatchNamespace() string
+	Metadata() metav1.ObjectMeta
 	AllowCrossNamespace() bool
 	CommonStatus() *GrafanaCommonStatus
 }

api/v1beta1/grafanaalertrulegroup_types.go

@@ -202,6 +202,10 @@ func (in *GrafanaAlertRuleGroup) MatchNamespace() string {
 	return in.Namespace
 }
 
+func (in *GrafanaAlertRuleGroup) Metadata() metav1.ObjectMeta {
+	return in.ObjectMeta
+}
+
 func (in *GrafanaAlertRuleGroup) AllowCrossNamespace() bool {
 	return in.Spec.AllowCrossNamespaceImport
 }

api/v1beta1/grafanacontactpoint_types.go

@@ -104,6 +104,10 @@ func (in *GrafanaContactPoint) MatchNamespace() string {
 	return in.Namespace
 }
 
+func (in *GrafanaContactPoint) Metadata() metav1.ObjectMeta {
+	return in.ObjectMeta
+}
+
 func (in *GrafanaContactPoint) AllowCrossNamespace() bool {
 	return in.Spec.AllowCrossNamespaceImport
 }

api/v1beta1/grafanadashboard_types.go

@@ -139,6 +139,10 @@ func (in *GrafanaDashboard) MatchNamespace() string {
 	return in.Namespace
 }
 
+func (in *GrafanaDashboard) Metadata() metav1.ObjectMeta {
+	return in.ObjectMeta
+}
+
 func (in *GrafanaDashboard) AllowCrossNamespace() bool {
 	return in.Spec.AllowCrossNamespaceImport
 }

api/v1beta1/grafanadatasource_types.go

@@ -164,6 +164,10 @@ func (in *GrafanaDatasource) MatchNamespace() string {
 	return in.Namespace
 }
 
+func (in *GrafanaDatasource) Metadata() metav1.ObjectMeta {
+	return in.ObjectMeta
+}
+
 func (in *GrafanaDatasource) AllowCrossNamespace() bool {
 	return in.Spec.AllowCrossNamespaceImport
 }

api/v1beta1/grafanafolder_types.go

@@ -171,6 +171,10 @@ func (in *GrafanaFolder) MatchNamespace() string {
 	return in.Namespace
 }
 
+func (in *GrafanaFolder) Metadata() metav1.ObjectMeta {
+	return in.ObjectMeta
+}
+
 func (in *GrafanaFolder) AllowCrossNamespace() bool {
 	return in.Spec.AllowCrossNamespaceImport
 }

api/v1beta1/grafanalibrarypanel_types.go

@@ -89,6 +89,10 @@ func (in *GrafanaLibraryPanel) MatchNamespace() string {
 	return in.Namespace
 }
 
+func (in *GrafanaLibraryPanel) Metadata() metav1.ObjectMeta {
+	return in.ObjectMeta
+}
+
 func (in *GrafanaLibraryPanel) AllowCrossNamespace() bool {
 	return in.Spec.AllowCrossNamespaceImport
 }

api/v1beta1/grafanamutetiming_types.go

@@ -101,6 +101,10 @@ func (in *GrafanaMuteTiming) MatchNamespace() string {
 	return in.Namespace
 }
 
+func (in *GrafanaMuteTiming) Metadata() metav1.ObjectMeta {
+	return in.ObjectMeta
+}
+
 func (in *GrafanaMuteTiming) AllowCrossNamespace() bool {
 	return in.Spec.AllowCrossNamespaceImport
 }

api/v1beta1/grafananotificationpolicy_types.go

@@ -216,6 +216,10 @@ func (in *GrafanaNotificationPolicy) MatchNamespace() string {
 	return in.Namespace
 }
 
+func (in *GrafanaNotificationPolicy) Metadata() metav1.ObjectMeta {
+	return in.ObjectMeta
+}
+
 func (in *GrafanaNotificationPolicy) AllowCrossNamespace() bool {
 	return in.Spec.AllowCrossNamespaceImport
 }

api/v1beta1/grafananotificationtemplate_types.go

@@ -62,6 +62,10 @@ func (in *GrafanaNotificationTemplate) MatchNamespace() string {
 	return in.Namespace
 }
 
+func (in *GrafanaNotificationTemplate) Metadata() metav1.ObjectMeta {
+	return in.ObjectMeta
+}
+
 func (in *GrafanaNotificationTemplate) AllowCrossNamespace() bool {
 	return in.Spec.AllowCrossNamespaceImport
 }