Skip to content

Commit 761c95d

Browse files
committed
fix(NotificationPolicy): finalize skip condition should be "or"
1 parent d439049 commit 761c95d

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

controllers/notificationpolicy_controller.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,8 +317,9 @@ func (r *GrafanaNotificationPolicyReconciler) finalize(ctx context.Context, noti
317317

318318
for _, grafana := range instances {
319319
appliedPolicy := grafana.Annotations[annotationAppliedNotificationPolicy]
320-
if appliedPolicy != "" && appliedPolicy != notificationPolicy.NamespacedResource() {
321-
log.Info("instance already has a different notification policy applied - skipping", "grafana", grafana.Name)
320+
321+
if appliedPolicy == "" || appliedPolicy != notificationPolicy.NamespacedResource() {
322+
log.Info("notification policy not applied to instance - skipping finalize", "grafana", grafana.Name, "policy", appliedPolicy)
322323
continue
323324
}
324325

0 commit comments

Comments
 (0)