Live: Add watch scope and allow dots in namespace (#1269)

Author: ryantxu

live/channel.go

@@ -69,7 +69,7 @@ func (c Channel) String() string {
 }
 
 var (
-	scopeNamespacePattern = regexp.MustCompile(`^[A-z0-9_\-]*$`)
+	scopeNamespacePattern = regexp.MustCompile(`^[A-z0-9_\-\.]*$`)
 	pathPattern           = regexp.MustCompile(`^[A-z0-9_\-/=.]*$`)
 )
 

live/channel_test.go

@@ -96,6 +96,21 @@ func TestParseChannel_IsValid(t *testing.T) {
 			id:      "grafana=/test=/path/dash-and-equal",
 			isValid: false,
 		},
+		{
+			name:    "scope_watch_dashboards",
+			id:      "watch/dashboard.grafana.app/dashboards",
+			isValid: true,
+		},
+		{
+			name:    "scope_watch_dashboards_with_user_id",
+			id:      "watch/dashboard.grafana.app/dashboards/userid",
+			isValid: true,
+		},
+		{
+			name:    "scope_watch_dashboards_with_name_anduser_id",
+			id:      "watch/dashboard.grafana.app/dashboards=XYZ/userid",
+			isValid: true,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {

live/scope.go

@@ -9,4 +9,6 @@ const (
 	ScopeDatasource = "ds"
 	// ScopeStream is a managed data frame stream.
 	ScopeStream = "stream"
+	// ScopeWatch will watch a k8s style resource
+	ScopeWatch = "watch"
 )