Skip to content

Commit 3795667

Browse files
authored
update protobuf (#1264)
1 parent 313d8fd commit 3795667

File tree

5 files changed

+658
-974
lines changed

5 files changed

+658
-974
lines changed

backend/convert_from_protobuf.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,10 +248,14 @@ func (f ConvertFromProtobuf) CollectMetricsResponse(protoResp *pluginv2.CollectM
248248

249249
// SubscribeStreamRequest ...
250250
func (f ConvertFromProtobuf) SubscribeStreamRequest(protoReq *pluginv2.SubscribeStreamRequest) *SubscribeStreamRequest {
251+
if protoReq.Headers == nil {
252+
protoReq.Headers = map[string]string{}
253+
}
251254
return &SubscribeStreamRequest{
252255
PluginContext: f.PluginContext(protoReq.PluginContext),
253256
Path: protoReq.GetPath(),
254257
Data: protoReq.GetData(),
258+
Headers: protoReq.Headers,
255259
}
256260
}
257261

@@ -267,10 +271,14 @@ func (f ConvertFromProtobuf) SubscribeStreamResponse(protoReq *pluginv2.Subscrib
267271

268272
// PublishStreamRequest ...
269273
func (f ConvertFromProtobuf) PublishStreamRequest(protoReq *pluginv2.PublishStreamRequest) *PublishStreamRequest {
274+
if protoReq.Headers == nil {
275+
protoReq.Headers = map[string]string{}
276+
}
270277
return &PublishStreamRequest{
271278
PluginContext: f.PluginContext(protoReq.PluginContext),
272279
Path: protoReq.GetPath(),
273280
Data: protoReq.GetData(),
281+
Headers: protoReq.Headers,
274282
}
275283
}
276284

@@ -284,10 +292,14 @@ func (f ConvertFromProtobuf) PublishStreamResponse(protoReq *pluginv2.PublishStr
284292

285293
// RunStreamRequest ...
286294
func (f ConvertFromProtobuf) RunStreamRequest(protoReq *pluginv2.RunStreamRequest) *RunStreamRequest {
295+
if protoReq.Headers == nil {
296+
protoReq.Headers = map[string]string{}
297+
}
287298
return &RunStreamRequest{
288299
PluginContext: f.PluginContext(protoReq.PluginContext),
289300
Path: protoReq.GetPath(),
290301
Data: protoReq.GetData(),
302+
Headers: protoReq.Headers,
291303
}
292304
}
293305

backend/convert_from_protobuf_test.go

Lines changed: 84 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -481,6 +481,90 @@ func TestConvertFromProtobufCheckHealthRequest(t *testing.T) {
481481
})
482482
}
483483

484+
func TestConvertFromProtobufSubscribeStreamRequest(t *testing.T) {
485+
t.Run("Should convert provided headers", func(t *testing.T) {
486+
protoReq := &pluginv2.SubscribeStreamRequest{
487+
PluginContext: protoPluginContext,
488+
Headers: map[string]string{
489+
"foo": "fooVal",
490+
"bar": "barVal",
491+
},
492+
}
493+
494+
req := FromProto().SubscribeStreamRequest(protoReq)
495+
require.NotNil(t, req)
496+
require.NotNil(t, req.PluginContext)
497+
require.Equal(t, protoPluginContext.OrgId, req.PluginContext.OrgID)
498+
require.Equal(t, protoReq.Headers, req.Headers)
499+
})
500+
501+
t.Run("Should handle nil-provided headers", func(t *testing.T) {
502+
protoReq := &pluginv2.SubscribeStreamRequest{
503+
PluginContext: protoPluginContext,
504+
}
505+
506+
req := FromProto().SubscribeStreamRequest(protoReq)
507+
require.NotNil(t, req)
508+
require.Equal(t, map[string]string{}, req.Headers)
509+
})
510+
}
511+
512+
func TestConvertFromProtobufPublishStreamRequest(t *testing.T) {
513+
t.Run("Should convert provided headers", func(t *testing.T) {
514+
protoReq := &pluginv2.PublishStreamRequest{
515+
PluginContext: protoPluginContext,
516+
Headers: map[string]string{
517+
"foo": "fooVal",
518+
"bar": "barVal",
519+
},
520+
}
521+
522+
req := FromProto().PublishStreamRequest(protoReq)
523+
require.NotNil(t, req)
524+
require.NotNil(t, req.PluginContext)
525+
require.Equal(t, protoPluginContext.OrgId, req.PluginContext.OrgID)
526+
require.Equal(t, protoReq.Headers, req.Headers)
527+
})
528+
529+
t.Run("Should handle nil-provided headers", func(t *testing.T) {
530+
protoReq := &pluginv2.PublishStreamRequest{
531+
PluginContext: protoPluginContext,
532+
}
533+
534+
req := FromProto().PublishStreamRequest(protoReq)
535+
require.NotNil(t, req)
536+
require.Equal(t, map[string]string{}, req.Headers)
537+
})
538+
}
539+
540+
func TestConvertFromProtobufRunStreamRequest(t *testing.T) {
541+
t.Run("Should convert provided headers", func(t *testing.T) {
542+
protoReq := &pluginv2.RunStreamRequest{
543+
PluginContext: protoPluginContext,
544+
Headers: map[string]string{
545+
"foo": "fooVal",
546+
"bar": "barVal",
547+
},
548+
}
549+
550+
req := FromProto().RunStreamRequest(protoReq)
551+
require.NotNil(t, req)
552+
require.NotNil(t, req.PluginContext)
553+
require.Equal(t, protoPluginContext.OrgId, req.PluginContext.OrgID)
554+
require.Equal(t, protoReq.Headers, req.Headers)
555+
})
556+
557+
t.Run("Should handle nil-provided headers", func(t *testing.T) {
558+
protoReq := &pluginv2.RunStreamRequest{
559+
PluginContext: protoPluginContext,
560+
}
561+
562+
req := FromProto().RunStreamRequest(protoReq)
563+
require.NotNil(t, req)
564+
require.Equal(t, map[string]string{}, req.Headers)
565+
})
566+
}
567+
484568
func TestConvertFromProtobufDataResponse(t *testing.T) {
485569
t.Run("Should convert data query response", func(t *testing.T) {
486570
tcs := []struct {

backend/convert_to_protobuf.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,7 @@ func (t ConvertToProtobuf) RunStreamRequest(req *RunStreamRequest) *pluginv2.Run
272272
PluginContext: t.PluginContext(req.PluginContext),
273273
Path: req.Path,
274274
Data: req.Data,
275+
Headers: req.Headers,
275276
}
276277
return protoReq
277278
}
@@ -282,6 +283,7 @@ func (t ConvertToProtobuf) SubscribeStreamRequest(req *SubscribeStreamRequest) *
282283
PluginContext: t.PluginContext(req.PluginContext),
283284
Path: req.Path,
284285
Data: req.Data,
286+
Headers: req.Headers,
285287
}
286288
}
287289

@@ -302,6 +304,7 @@ func (t ConvertToProtobuf) PublishStreamRequest(req *PublishStreamRequest) *plug
302304
PluginContext: t.PluginContext(req.PluginContext),
303305
Path: req.Path,
304306
Data: req.Data,
307+
Headers: req.Headers,
305308
}
306309
}
307310

0 commit comments

Comments
 (0)