Include macro filtering for hosts #1921
Conversation
|
|
|
Can you please open an issue for this first where you describe the problem that you are trying to solve? |
|
Hello here is the linked issue to this request : |
|
Also you need to accept the CLA. |
ozarrouki
force-pushed
the
include-macro-filtering-for-hosts
branch
from
e196872 to
4fb5863
Compare
There was a problem hiding this comment.
these files show as modifed when they were not i added a space to see the contents
There was a problem hiding this comment.
these files show as modifed when they were not i added a space to see the contents
There was a problem hiding this comment.
these files show as modifed when they were not i added a space to see the contents
|
src/datasource/zabbix/zabbix.ts L213 that extra 'n' before comment seems not good. |
zoltanbedi
left a comment
zoltanbedi
left a comment
There was a problem hiding this comment.
I looked at the code again but I'd like to have a better understanding on what we want to achieve here before we go into implementation details.
| return this.request('usermacro.get', params); | ||
| } | ||
|
|
||
| getMacrosByGroup(groupids) { |
There was a problem hiding this comment.
I don't understand the need for 2 different functions. The other one only misses 3 fields.
There was a problem hiding this comment.
Also why don't you use the getMacros function above and extend that with the groupids?
|
Also it would be best to try to create smaller PRs that only focus on one aspect at a time. It would help us reviewing the code faster. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions! |
|
This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had any further activity in the last 2 weeks. Thank you for your contributions! |
5 participants
Summary:
Support for Query Types: Added support for querying user macro names and user macro values.
Filtering Hosts: Implemented the ability to filter hosts in Zabbix using user macro names and values.
Regex Filtering: Enhanced filtering capabilities by adding support for regular expression (regex) filtering on user macro names and values.
These changes aim to improve the flexibility and precision of host filtering in Zabbix, making it easier to manage and visualize data in Grafana.
Changes:
Added query types for user macro names and values.
Implemented filtering logic for hosts based on user macros.
Added regex support for user macro filtering in Variable settings.
Screeshots:
Fixes #1926