Move health check to the backend #2120
Conversation
| */ | ||
| async testDatasource() { | ||
| const backendDS = new DataSourceWithBackend(this.instanceSettings); | ||
| try { |
There was a problem hiding this comment.
For this, I am using this approach for now, but it should be temporary, I have a separate issue to track migrating from DatasourceApi to DatasourceWithBackend when this is complete we will no longer need to have this here.
itsmylife
left a comment
itsmylife
left a comment
There was a problem hiding this comment.
It looks good but we need to double check if we still need testDatasource()
zoltanbedi
changed the title
|
Levitate is-compatible report: 🔍 Resolving @grafana/data@latest... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... ✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/schema,@grafana/e2e-selectors,@grafana/experimental |
This PR moves the health check to backend only leaving in the frontend the functionality to test the dbconnector datasource.
Leaving the
dbconnector.testDataSourceshould be fine since the datasource types we allow for db connection with Zabbix already are backend datasources, and so their health requests would go through the backend.Verified:
Clicking test and seeing a
healthrequest go out.IMPORTANT: While testing this in the UI, I found a bug with the config editor - whenever a change is made in the UI and tested, the changes don't take effect (i.e. disabling trends, keeps
trendsset totrue, enabling db connection keepdbConnectionEnabledset tofalseand so on.). Created a separate issue to fix thisFixes https://github.com/grafana/oss-big-tent-squad/issues/124
Fixes #2004