Skip to content

Conversation

@samjewell
Copy link
Contributor

What is this feature?

Bump Go MySQL Server to the latest version, to get support for STDDEV()
and VARIANCE() functions, and their aliases.

See dolthub/go-mysql-server#2928

Why do we need this feature?

Anticipating that people might call these functions and expect them to work

Who is this feature for?

People using SQL Expressions

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

Bump Go MySQL Server to the latest version, to get support for STDDEV()
and VARIANCE() functions, and their aliases.

See dolthub/go-mysql-server#2928
@samjewell samjewell requested review from gabor and kylebrandt April 11, 2025 08:32
@samjewell samjewell self-assigned this Apr 11, 2025
@samjewell samjewell requested review from a team as code owners April 11, 2025 08:32
@samjewell samjewell requested review from IfSentient and removed request for a team April 11, 2025 08:32
@github-actions github-actions bot added this to the 12.0.x milestone Apr 11, 2025
@samjewell samjewell marked this pull request as draft April 11, 2025 10:28
@samjewell samjewell added area/expressions/sql The SQL expressions feature that is part of Server Side Expressions no-changelog Skip including change in changelog/release notes and removed add to changelog labels Apr 11, 2025
@samjewell samjewell marked this pull request as ready for review April 11, 2025 12:59
@samjewell samjewell requested a review from a team as a code owner April 11, 2025 12:59
@samjewell samjewell requested review from suntala and removed request for a team April 11, 2025 12:59
}

func (ri *rowIter) Next(_ *mysql.Context) (mysql.Row, error) {
func (ri *rowIter) Next(ctx *mysql.Context) (mysql.Row, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@samjewell samjewell merged commit 5c41819 into main Apr 15, 2025
54 checks passed
@samjewell samjewell deleted the sj/sql-expr-bump-gms-stddev-variance branch April 15, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/backend area/expressions/sql The SQL expressions feature that is part of Server Side Expressions no-changelog Skip including change in changelog/release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants