Skip to content

Commit c97a333

Browse files
Merge pull request #3954 from hwwi/main
[tempo-distributed] Add missing global extraArgs, extraEnv, extraEnvFrom
2 parents 93c9499 + 69e7436 commit c97a333

File tree

5 files changed

+35
-9
lines changed

5 files changed

+35
-9
lines changed

charts/tempo-distributed/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: tempo-distributed
33
description: Grafana Tempo in MicroService mode
44
type: application
5-
version: 1.52.7
5+
version: 1.52.8
66
appVersion: 2.9.0
77
engine: gotpl
88
home: https://grafana.com/docs/tempo/latest/

charts/tempo-distributed/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# tempo-distributed
22

3-
![Version: 1.52.7](https://img.shields.io/badge/Version-1.52.7-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.9.0](https://img.shields.io/badge/AppVersion-2.9.0-informational?style=flat-square)
3+
![Version: 1.52.8](https://img.shields.io/badge/Version-1.52.8-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.9.0](https://img.shields.io/badge/AppVersion-2.9.0-informational?style=flat-square)
44

55
Grafana Tempo in MicroService mode
66

charts/tempo-distributed/templates/memcached/statefulset-memcached.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,14 @@ spec:
5757
- image: {{ include "tempo.imageReference" $dict }}
5858
imagePullPolicy: {{ .Values.memcached.image.pullPolicy }}
5959
name: memcached
60-
{{- with .Values.memcached.extraArgs }}
60+
{{- if or .Values.global.extraArgs .Values.memcached.extraArgs }}
6161
args:
62+
{{- with .Values.memcached.extraArgs }}
6263
{{- toYaml . | nindent 12 }}
64+
{{- end }}
65+
{{- with .Values.global.extraArgs }}
66+
{{- toYaml . | nindent 12 }}
67+
{{- end }}
6368
{{- end }}
6469
ports:
6570
- containerPort: 11211

charts/tempo-distributed/templates/metrics-generator/deployment-metrics-generator.yaml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,9 @@ spec:
6161
{{- with .Values.metricsGenerator.extraArgs }}
6262
{{- toYaml . | nindent 12 }}
6363
{{- end }}
64+
{{- with .Values.global.extraArgs }}
65+
{{- toYaml . | nindent 12 }}
66+
{{- end }}
6467
image: {{ include "tempo.imageReference" $dict }}
6568
imagePullPolicy: {{ .Values.tempo.image.pullPolicy }}
6669
name: metrics-generator
@@ -78,9 +81,14 @@ spec:
7881
{{- toYaml . | nindent 12 }}
7982
{{- end }}
8083
{{- end }}
81-
{{- with .Values.metricsGenerator.extraEnvFrom }}
84+
{{- if or .Values.global.extraEnvFrom .Values.metricsGenerator.extraEnvFrom }}
8285
envFrom:
83-
{{- toYaml . | nindent 12 }}
86+
{{- with .Values.global.extraEnvFrom }}
87+
{{- toYaml . | nindent 12 }}
88+
{{- end }}
89+
{{- with .Values.metricsGenerator.extraEnvFrom }}
90+
{{- toYaml . | nindent 12 }}
91+
{{- end }}
8492
{{- end }}
8593
livenessProbe:
8694
{{- toYaml .Values.tempo.livenessProbe | nindent 12 }}

charts/tempo-distributed/templates/query-frontend/deployment-query-frontend.yaml

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,9 @@ spec:
6666
{{- with .Values.queryFrontend.extraArgs }}
6767
{{- toYaml . | nindent 12 }}
6868
{{- end }}
69+
{{- with .Values.global.extraArgs }}
70+
{{- toYaml . | nindent 12 }}
71+
{{- end }}
6972
image: {{ include "tempo.imageReference" $dict }}
7073
imagePullPolicy: {{ .Values.tempo.image.pullPolicy }}
7174
name: query-frontend
@@ -133,13 +136,23 @@ spec:
133136
name: jaeger-ui
134137
- containerPort: 16687
135138
name: jaeger-metrics
136-
{{- with .Values.queryFrontend.query.extraEnv }}
139+
{{- if or .Values.global.extraEnv .Values.queryFrontend.query.extraEnv }}
137140
env:
138-
{{- toYaml . | nindent 12 }}
141+
{{- with .Values.global.extraEnv }}
142+
{{- toYaml . | nindent 12 }}
143+
{{- end }}
144+
{{- with .Values.queryFrontend.query.extraEnv }}
145+
{{- toYaml . | nindent 12 }}
146+
{{- end }}
139147
{{- end }}
140-
{{- with .Values.queryFrontend.query.extraEnvFrom }}
148+
{{- if or .Values.global.extraEnvFrom .Values.queryFrontend.query.extraEnvFrom }}
141149
envFrom:
142-
{{- toYaml . | nindent 12 }}
150+
{{- with .Values.global.extraEnvFrom }}
151+
{{- toYaml . | nindent 12 }}
152+
{{- end }}
153+
{{- with .Values.queryFrontend.query.extraEnvFrom }}
154+
{{- toYaml . | nindent 12 }}
155+
{{- end }}
143156
{{- end }}
144157
resources:
145158
{{- toYaml .Values.queryFrontend.query.resources | nindent 12 }}

0 commit comments

Comments
 (0)