Skip to content

Commit db0e776

Browse files
author
Muhammad Shahzeb
authored
Update tracing pipeline dashboard for Grafana Agent mixin (#1182)
* Update tracing pipeline dashboard * Remove OTEL LB row * Update fmt
1 parent f955010 commit db0e776

File tree

1 file changed

+17
-15
lines changed

1 file changed

+17
-15
lines changed

grafana-agent-mixin/dashboards/grafana-agent.libsonnet

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ local instance_template = grafana.template.new(
452452
fill=0,
453453
)
454454
.addTarget(prometheus.target(
455-
'rate(traces_receiver_accepted_spans{' + host_matcher + ',receiver!="otlp/lb"}[$__rate_interval])',
455+
'rate(traces_receiver_accepted_spans_total{' + host_matcher + ',receiver!="otlp/lb"}[$__rate_interval])',
456456
legendFormat='{{ instance }} - {{ receiver }}/{{ transport }}',
457457
)) +
458458
utils.timeSeriesOverride(unit='short');
@@ -468,7 +468,7 @@ local instance_template = grafana.template.new(
468468
fill=0,
469469
)
470470
.addTarget(prometheus.target(
471-
'rate(traces_receiver_refused_spans{' + host_matcher + ',receiver!="otlp/lb"}[$__rate_interval])',
471+
'rate(traces_receiver_refused_spans_total{' + host_matcher + ',receiver!="otlp/lb"}[$__rate_interval])',
472472
legendFormat='{{ instance }} - {{ receiver }}/{{ transport }}',
473473
)) +
474474
utils.timeSeriesOverride(unit='short');
@@ -484,7 +484,7 @@ local instance_template = grafana.template.new(
484484
fill=0,
485485
)
486486
.addTarget(prometheus.target(
487-
'rate(traces_exporter_sent_spans{' + host_matcher + ',exporter!="otlp"}[$__rate_interval])',
487+
'rate(traces_exporter_sent_spans_total{' + host_matcher + ',exporter!="otlp"}[$__rate_interval])',
488488
legendFormat='{{ instance }} - {{ exporter }}',
489489
)) +
490490
utils.timeSeriesOverride(unit='short');
@@ -500,7 +500,7 @@ local instance_template = grafana.template.new(
500500
fill=0,
501501
)
502502
.addTarget(prometheus.target(
503-
'rate(traces_exporter_send_failed_spans{' + host_matcher + ',exporter!="otlp"}[$__rate_interval])',
503+
'rate(traces_exporter_send_failed_spans_total{' + host_matcher + ',exporter!="otlp"}[$__rate_interval])',
504504
legendFormat='{{ instance }} - {{ exporter }}',
505505
)) +
506506
utils.timeSeriesOverride(unit='short');
@@ -515,11 +515,11 @@ local instance_template = grafana.template.new(
515515
fill=1,
516516
)
517517
.addTarget(prometheus.target(
518-
'sum(rate(traces_receiver_accepted_spans{' + host_matcher + ',%s}[$__rate_interval]))' % receiverFilter,
518+
'sum(rate(traces_receiver_accepted_spans_total{' + host_matcher + ',%s}[$__rate_interval]))' % receiverFilter,
519519
legendFormat='Accepted',
520520
))
521521
.addTarget(prometheus.target(
522-
'sum(rate(traces_receiver_refused_spans{' + host_matcher + ',%s}[$__rate_interval])) ' % receiverFilter,
522+
'sum(rate(traces_receiver_refused_spans_total{' + host_matcher + ',%s}[$__rate_interval])) ' % receiverFilter,
523523
legendFormat='Refused',
524524
)) +
525525
utils.timeSeriesOverride(unit='short');
@@ -534,11 +534,11 @@ local instance_template = grafana.template.new(
534534
fill=1,
535535
)
536536
.addTarget(prometheus.target(
537-
'sum(rate(traces_exporter_sent_spans{' + host_matcher + ',%s}[$__rate_interval]))' % exporterFilter,
537+
'sum(rate(traces_exporter_sent_spans_total{' + host_matcher + ',%s}[$__rate_interval]))' % exporterFilter,
538538
legendFormat='Sent',
539539
))
540540
.addTarget(prometheus.target(
541-
'sum(rate(traces_exporter_send_failed_spans{' + host_matcher + ',%s}[$__rate_interval]))' % exporterFilter,
541+
'sum(rate(traces_exporter_send_failed_spans_total{' + host_matcher + ',%s}[$__rate_interval]))' % exporterFilter,
542542
legendFormat='Send failed',
543543
)) +
544544
utils.timeSeriesOverride(unit='short');
@@ -596,13 +596,15 @@ local instance_template = grafana.template.new(
596596
.addPanel(exportedFailedSpans)
597597
.addPanel(receivedSpans('receiver!="otlp/lb"', 6))
598598
.addPanel(exportedSpans('exporter!="otlp"', 6))
599-
)
600-
.addRow(
601-
row.new('Load balancing')
602-
.addPanel(loadBalancedSpans)
603-
.addPanel(peersNum)
604-
.addPanel(receivedSpans('receiver="otlp/lb"', 3))
605-
.addPanel(exportedSpans('exporter="otlp"', 3))
606599
),
600+
// TODO(ptodev): Uncomment this when Collector has instrumeneted LB exporter using OTel:
601+
// https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/29867
602+
// .addRow(
603+
// row.new('Load balancing')
604+
// .addPanel(loadBalancedSpans)
605+
// .addPanel(peersNum)
606+
// .addPanel(receivedSpans('receiver="otlp/lb"', 3))
607+
// .addPanel(exportedSpans('exporter="otlp"', 3))
608+
// ),
607609
},
608610
}

0 commit comments

Comments
 (0)