Skip to content

Commit df89c66

Browse files
schmikeiv-zhuravlev
schmikei
authored and
v-zhuravlev
committed
remove redundant wrapPanels
1 parent 18f7387 commit df89c66

File tree

4 files changed

+67
-67
lines changed

4 files changed

+67
-67
lines changed

‎clickhouse-mixin/dashboards.libsonnet

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@ local logslib = import "logs-lib/logs/main.libsonnet";
2020
+ g.dashboard.withPanels(
2121
g.util.grid.wrapPanels(
2222
[
23-
panels.interserverConnectionsPanel { gridPos+: { h: 8, w: 12, x: 0, y: 0 } },
24-
panels.replicaQueueSizePanel { gridPos+: { h: 8, w: 12, x: 12, y: 0 } },
25-
panels.replicaOperationsPanel { gridPos+: { h: 8, w: 12, x: 0, y: 8 } },
26-
panels.replicaReadOnlyPanel { gridPos+: { h: 8, w: 12, x: 12, y: 8 } },
27-
panels.zooKeeperWatchesPanel { gridPos+: { h: 8, w: 12, x: 0, y: 16 } },
28-
panels.zooKeeperSessionsPanel { gridPos+: { h: 8, w: 12, x: 12, y: 16 } },
29-
panels.zooKeeperRequestsPanel { gridPos+: { h: 8, w: 24, x: 0, y: 24 } },
23+
panels.interserverConnectionsPanel,
24+
panels.replicaQueueSizePanel,
25+
panels.replicaOperationsPanel,
26+
panels.replicaReadOnlyPanel,
27+
panels.zooKeeperWatchesPanel,
28+
panels.zooKeeperSessionsPanel,
29+
panels.zooKeeperRequestsPanel,
3030
]
3131
)
3232
)
@@ -46,14 +46,14 @@ local logslib = import "logs-lib/logs/main.libsonnet";
4646
+ g.dashboard.withPanels(
4747
g.util.grid.wrapPanels(
4848
[
49-
panels.successfulQueriesPanel { gridPos+: { h: 8, w: 24, x: 0, y: 0 } },
50-
panels.failedQueriesPanel { gridPos+: { h: 8, w: 12, x: 0, y: 8 } },
51-
panels.rejectedInsertsPanel { gridPos+: { h: 8, w: 12, x: 12, y: 8 } },
52-
panels.memoryUsagePanel { gridPos+: { h: 8, w: 12, x: 0, y: 16 } },
53-
panels.memoryUsageGaugePanel { gridPos+: { h: 8, w: 12, x: 12, y: 16 } },
54-
panels.activeConnectionsPanel { gridPos+: { h: 8, w: 24, x: 0, y: 24 } },
55-
panels.networkReceivedPanel { gridPos+: { h: 8, w: 12, x: 0, y: 32 } },
56-
panels.networkTransmittedPanel { gridPos+: { h: 8, w: 12, x: 12, y: 32 } },
49+
panels.successfulQueriesPanel,
50+
panels.failedQueriesPanel,
51+
panels.rejectedInsertsPanel,
52+
panels.memoryUsagePanel,
53+
panels.memoryUsageGaugePanel,
54+
panels.activeConnectionsPanel,
55+
panels.networkReceivedPanel,
56+
panels.networkTransmittedPanel,
5757
]
5858
)
5959
)
@@ -73,11 +73,11 @@ local logslib = import "logs-lib/logs/main.libsonnet";
7373
+ g.dashboard.withPanels(
7474
g.util.grid.wrapPanels(
7575
[
76-
panels.diskReadLatencyPanel { gridPos+: { h: 8, w: 12, x: 0, y: 0 } },
77-
panels.diskWriteLatencyPanel { gridPos+: { h: 8, w: 12, x: 12, y: 0 } },
78-
panels.networkTransmitLatencyInboundPanel { gridPos+: { h: 8, w: 12, x: 0, y: 8 } },
79-
panels.networkTransmitLatencyOutboundPanel { gridPos+: { h: 8, w: 12, x: 12, y: 8 } },
80-
panels.zooKeeperWaitTimePanel { gridPos+: { h: 8, w: 24, x: 0, y: 16 } },
76+
panels.diskReadLatencyPanel,
77+
panels.diskWriteLatencyPanel,
78+
panels.networkTransmitLatencyInboundPanel,
79+
panels.networkTransmitLatencyOutboundPanel,
80+
panels.zooKeeperWaitTimePanel,
8181
]
8282
)
8383
)

‎clickhouse-mixin/dashboards_out/clickhouse-latency

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
},
5555
"gridPos": {
5656
"h": 8,
57-
"w": 12,
57+
"w": 8,
5858
"x": 0,
5959
"y": 0
6060
},
@@ -104,8 +104,8 @@
104104
},
105105
"gridPos": {
106106
"h": 8,
107-
"w": 12,
108-
"x": 12,
107+
"w": 8,
108+
"x": 8,
109109
"y": 0
110110
},
111111
"id": 2,
@@ -154,9 +154,9 @@
154154
},
155155
"gridPos": {
156156
"h": 8,
157-
"w": 12,
158-
"x": 0,
159-
"y": 8
157+
"w": 8,
158+
"x": 16,
159+
"y": 0
160160
},
161161
"id": 3,
162162
"options": {
@@ -204,8 +204,8 @@
204204
},
205205
"gridPos": {
206206
"h": 8,
207-
"w": 12,
208-
"x": 12,
207+
"w": 8,
208+
"x": 0,
209209
"y": 8
210210
},
211211
"id": 4,
@@ -254,9 +254,9 @@
254254
},
255255
"gridPos": {
256256
"h": 8,
257-
"w": 24,
258-
"x": 0,
259-
"y": 16
257+
"w": 8,
258+
"x": 8,
259+
"y": 8
260260
},
261261
"id": 5,
262262
"options": {

‎clickhouse-mixin/dashboards_out/clickhouse-overview

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
},
5555
"gridPos": {
5656
"h": 8,
57-
"w": 24,
57+
"w": 8,
5858
"x": 0,
5959
"y": 0
6060
},
@@ -120,9 +120,9 @@
120120
},
121121
"gridPos": {
122122
"h": 8,
123-
"w": 12,
124-
"x": 0,
125-
"y": 8
123+
"w": 8,
124+
"x": 8,
125+
"y": 0
126126
},
127127
"id": 2,
128128
"options": {
@@ -178,9 +178,9 @@
178178
},
179179
"gridPos": {
180180
"h": 8,
181-
"w": 12,
182-
"x": 12,
183-
"y": 8
181+
"w": 8,
182+
"x": 16,
183+
"y": 0
184184
},
185185
"id": 3,
186186
"options": {
@@ -228,9 +228,9 @@
228228
},
229229
"gridPos": {
230230
"h": 8,
231-
"w": 12,
231+
"w": 8,
232232
"x": 0,
233-
"y": 16
233+
"y": 8
234234
},
235235
"id": 4,
236236
"options": {
@@ -265,9 +265,9 @@
265265
"description": "Percentage of memory allocated by ClickHouse compared to OS total",
266266
"gridPos": {
267267
"h": 8,
268-
"w": 12,
269-
"x": 12,
270-
"y": 16
268+
"w": 8,
269+
"x": 8,
270+
"y": 8
271271
},
272272
"id": 5,
273273
"options": {
@@ -308,9 +308,9 @@
308308
},
309309
"gridPos": {
310310
"h": 8,
311-
"w": 24,
312-
"x": 0,
313-
"y": 24
311+
"w": 8,
312+
"x": 16,
313+
"y": 8
314314
},
315315
"id": 6,
316316
"options": {
@@ -382,9 +382,9 @@
382382
},
383383
"gridPos": {
384384
"h": 8,
385-
"w": 12,
385+
"w": 8,
386386
"x": 0,
387-
"y": 32
387+
"y": 16
388388
},
389389
"id": 7,
390390
"options": {
@@ -432,9 +432,9 @@
432432
},
433433
"gridPos": {
434434
"h": 8,
435-
"w": 12,
436-
"x": 12,
437-
"y": 32
435+
"w": 8,
436+
"x": 8,
437+
"y": 16
438438
},
439439
"id": 8,
440440
"options": {

‎clickhouse-mixin/dashboards_out/clickhouse-replica

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
},
5454
"gridPos": {
5555
"h": 8,
56-
"w": 12,
56+
"w": 8,
5757
"x": 0,
5858
"y": 0
5959
},
@@ -102,8 +102,8 @@
102102
},
103103
"gridPos": {
104104
"h": 8,
105-
"w": 12,
106-
"x": 12,
105+
"w": 8,
106+
"x": 8,
107107
"y": 0
108108
},
109109
"id": 2,
@@ -152,9 +152,9 @@
152152
},
153153
"gridPos": {
154154
"h": 8,
155-
"w": 12,
156-
"x": 0,
157-
"y": 8
155+
"w": 8,
156+
"x": 16,
157+
"y": 0
158158
},
159159
"id": 3,
160160
"options": {
@@ -225,8 +225,8 @@
225225
},
226226
"gridPos": {
227227
"h": 8,
228-
"w": 12,
229-
"x": 12,
228+
"w": 8,
229+
"x": 0,
230230
"y": 8
231231
},
232232
"id": 4,
@@ -274,9 +274,9 @@
274274
},
275275
"gridPos": {
276276
"h": 8,
277-
"w": 12,
278-
"x": 0,
279-
"y": 16
277+
"w": 8,
278+
"x": 8,
279+
"y": 8
280280
},
281281
"id": 5,
282282
"options": {
@@ -323,9 +323,9 @@
323323
},
324324
"gridPos": {
325325
"h": 8,
326-
"w": 12,
327-
"x": 12,
328-
"y": 16
326+
"w": 8,
327+
"x": 16,
328+
"y": 8
329329
},
330330
"id": 6,
331331
"options": {
@@ -372,9 +372,9 @@
372372
},
373373
"gridPos": {
374374
"h": 8,
375-
"w": 24,
375+
"w": 8,
376376
"x": 0,
377-
"y": 24
377+
"y": 16
378378
},
379379
"id": 7,
380380
"options": {

0 commit comments

Comments
 (0)