Skip to content

Commit 1237726

Browse files
committed
Fix the browser examples which work with check
check expects a function that returns a boolean. There is enough of a difference in what the k6 type definitions expect vs how the example k6 browser tests work with check. If a user works with the example browser tests as documented along with the type definitions then they will find an error in the example code. This commit fix those examples so that users will not see that error.
1 parent be36568 commit 1237726

File tree

13 files changed

+13
-13
lines changed

13 files changed

+13
-13
lines changed

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/04-element-handle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ export default async function () {
8282

8383
await Promise.all([page.waitForNavigation(), submitButton.click()]);
8484
check(page, {
85-
header: page.locator('h2').textContent() == 'Welcome, admin!',
85+
'header': page => page.locator('h2').textContent() == 'Welcome, admin!',
8686
});
8787
} finally {
8888
page.close();

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page/waitforloadstate--options--.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ export default async function () {
7171
page.waitForLoadState(); // waits for the default `load` event
7272

7373
check(page, {
74-
header: page.locator('h2').textContent() == 'Welcome, admin!',
74+
'header': page => page.locator('h2').textContent() == 'Welcome, admin!',
7575
});
7676
} finally {
7777
page.close();

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page/waitfornavigation--options--.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ export default async function () {
7171
await Promise.all([page.waitForNavigation(), submitButton.click()])
7272

7373
check(page, {
74-
header: page.locator('h2').textContent() == 'Welcome, admin!',
74+
'header': page => page.locator('h2').textContent() == 'Welcome, admin!',
7575
});
7676
} finally {
7777
page.close();

src/data/markdown/translated-guides/en/03 Using k6 browser/01 Overview.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export default async function () {
6565
await Promise.all([page.waitForNavigation(), submitButton.click()]);
6666

6767
check(page, {
68-
header: page.locator('h2').textContent() == 'Welcome, admin!',
68+
'header': page => page.locator('h2').textContent() == 'Welcome, admin!',
6969
});
7070
} finally {
7171
page.close();

src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ export default async function () {
225225
await Promise.all([page.waitForNavigation(), submitButton.click()]);
226226

227227
check(page, {
228-
header: page.locator('h2').textContent() == 'Welcome, admin!',
228+
'header': page => page.locator('h2').textContent() == 'Welcome, admin!',
229229
});
230230
} finally {
231231
page.close();

src/data/markdown/versioned-js-api/v0.43/javascript api/07 k6-experimental/01 browser/04-element-handle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export default async function () {
7373

7474
await Promise.all([page.waitForNavigation(), page.locator('input[type="submit"]').click()]);
7575
check(page, {
76-
header: page.locator('h2').textContent() == 'Welcome, admin!',
76+
'header': page => page.locator('h2').textContent() == 'Welcome, admin!',
7777
});
7878
} finally {
7979
page.close();

src/data/markdown/versioned-js-api/v0.43/javascript api/07 k6-experimental/01 browser/10-page.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export default async function () {
9595

9696
await Promise.all([page.waitForNavigation(), page.locator('input[type="submit"]').click()]);
9797
check(page, {
98-
header: page.locator('h2').textContent() == 'Welcome, admin!',
98+
'header': page => page.locator('h2').textContent() == 'Welcome, admin!',
9999
});
100100
} finally {
101101
page.close();

src/data/markdown/versioned-js-api/v0.44/javascript api/07 k6-experimental/01 browser/04-element-handle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export default async function () {
7474

7575
await Promise.all([page.waitForNavigation(), submitButton.click()]);
7676
check(page, {
77-
header: page.locator('h2').textContent() == 'Welcome, admin!',
77+
'header': page => page.locator('h2').textContent() == 'Welcome, admin!',
7878
});
7979
} finally {
8080
page.close();

src/data/markdown/versioned-js-api/v0.44/javascript api/07 k6-experimental/01 browser/10 Page/waitforloadstate--options--.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export default async function () {
5959
page.waitForLoadState(); // waits for the default `load` event
6060

6161
check(page, {
62-
header: page.locator('h2').textContent() == 'Welcome, admin!',
62+
'header': page => page.locator('h2').textContent() == 'Welcome, admin!',
6363
});
6464
} finally {
6565
page.close();

src/data/markdown/versioned-js-api/v0.44/javascript api/07 k6-experimental/01 browser/10 Page/waitfornavigation--options--.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export default async function () {
5959
await Promise.all([page.waitForNavigation(), submitButton.click()])
6060

6161
check(page, {
62-
header: page.locator('h2').textContent() == 'Welcome, admin!',
62+
'header': page => page.locator('h2').textContent() == 'Welcome, admin!',
6363
});
6464
} finally {
6565
page.close();

0 commit comments

Comments
 (0)