Skip to content

Commit 1a1e09d

Browse files
mdcruzankur22andrewslotin
authored
Apply suggestions from code review
Co-authored-by: Ankur <[email protected]> Co-authored-by: Andrey Slotin <[email protected]>
1 parent e76e293 commit 1a1e09d

File tree

10 files changed

+48
-48
lines changed

10 files changed

+48
-48
lines changed

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page.md

Lines changed: 29 additions & 29 deletions
Large diffs are not rendered by default.

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page/bringToFront.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ title: 'bringToFront()'
33
excerpt: 'Browser module: page.bringToFront method'
44
---
55

6-
Activates the browser tab so that it comes into focus and actions can be performed against it.
6+
Activates the browser tab which brings the page in focus to allow actions to be performed onto it.
77

88

99
### Example

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page/click--options--.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
2-
title: 'click(selector,[options)'
3-
excerpt: 'Browser module: page.click(selector,[options) method'
2+
title: 'click(selector[, options])'
3+
excerpt: 'Browser module: page.click(selector[, options]) method'
44
---
55

66
<Blockquote mod="note" title="">
@@ -9,7 +9,7 @@ Use locator-based [`locator.click([options])`](/javascript-api/k6-experimental/b
99

1010
</Blockquote>
1111

12-
This method clicks an element matching a `selector`.
12+
This method clicks on an element matching a `selector`.
1313

1414
<TableWithNestedRows>
1515

@@ -44,7 +44,7 @@ export default async function () {
4444
const page = browser.newPage();
4545

4646
await page.goto('https://test.k6.io/browser.php');
47-
await Promise.all([page.click('#counter-button')]);
47+
await page.click('#counter-button');
4848
}
4949
```
5050

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page/dispatchEvent--options--.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
---
2-
title: 'dispatchEvent(selector, type, eventInit, [options])'
3-
excerpt: 'Browser module: page.dispatchEvent(selector, type, eventInit, [options]) method'
2+
title: 'dispatchEvent(selector, type, eventInit[, options])'
3+
excerpt: 'Browser module: page.dispatchEvent(selector, type, eventInit[, options]) method'
44
---
55

66
<Blockquote mod="note" title="">
77

8-
Use locator-based [`locator.dispatchEvent(type, eventInit, [options])`](/javascript-api/k6-experimental/browser/locator/dispatchevent/) instead.
8+
Use locator-based [`locator.dispatchEvent(type, eventInit[, options])`](/javascript-api/k6-experimental/browser/locator/dispatchevent/) instead.
99

1010
</Blockquote>
1111

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page/evaluateHandle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ excerpt: 'Browser module: page.evaluateHandle(pageFunction[, arg]) method'
55

66
Returns the value of the `pageFunction` invocation as a [JSHandle](/javascript-api/k6-experimental/browser/jshandle/).
77

8-
The only difference between `page.evaluate` and `page.evaluateHandle` is that `page.evaluateHandle` returns [JSHandle](/javascript-api/k6-experimental/browser/jshandle/).
8+
The only difference between `page.evaluate()` and `page.evaluateHandle()` is that `page.evaluateHandle()` returns [JSHandle](/javascript-api/k6-experimental/browser/jshandle/).
99

1010
<TableWithNestedRows>
1111

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page/getattribute--options--.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
2-
title: 'getAttribute(selector, name, [options])'
3-
excerpt: 'Browser module: page.getAttribute(selector, name, [options]) method'
2+
title: 'getAttribute(selector, name[, options])'
3+
excerpt: 'Browser module: page.getAttribute(selector, name[, options]) method'
44
---
55

66
<Blockquote mod="note" title="">

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page/goto--options--.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
2-
title: 'goto(url, [options])'
3-
excerpt: 'Browser module: page.goto(url, [options]) method'
2+
title: 'goto(url[, options])'
3+
excerpt: 'Browser module: page.goto(url[, options]) method'
44
---
55

66
Navigates to the specified URL and returns the main resource response.

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page/press--options--.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
2-
title: 'press(selector, key, [options])'
3-
excerpt: 'Browser module: page.press(selector, key, [options]) method'
2+
title: 'press(selector, key[, options])'
3+
excerpt: 'Browser module: page.press(selector, key[, options]) method'
44
---
55

66
<Blockquote mod="note" title="">

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page/selectoption--options--.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
2-
title: 'selectOption(selector, values, [options])'
3-
excerpt: 'Browser module: page.selectOption(selector, values, [options]) method'
2+
title: 'selectOption(selector, values[, options])'
3+
excerpt: 'Browser module: page.selectOption(selector, values[, options]) method'
44
---
55

66
<Blockquote mod="note" title="">

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10 Page/setcontent--options--.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
2-
title: 'setContent(html, [options])'
3-
excerpt: 'Browser module: page.setContent(html, [options]) method'
2+
title: 'setContent(html[, options])'
3+
excerpt: 'Browser module: page.setContent(html[, options]) method'
44
---
55

66
Sets the supplied HTML string to the current page.

0 commit comments

Comments
 (0)