Since we're using Bash, I think local variables can really help with function readabliity

szkiba · jdbaldry · web-flow · commit 4a3efbe65a53 · 2024-09-30T15:07:34.000+02:00
thanks @jdbaldry Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
diff --git a/scripts/extension-registry-changed b/scripts/extension-registry-changed
@@ -26,9 +26,12 @@ curl -sL https://registry.k6.io/registry.json |
 }
 
 replace_extension_list_partial() {
-ed -s $1 <<EOF
+local -r outfile="$1"
+local -r infile="$2"
+
+ed -s "$outfile" <<EOF
 /<div class=.nav-cards.>/+,/<.div>/-d
-/<div class=.nav-cards.>/ r $2
+/<div class=.nav-cards.>/ r "$infile"
 w
 q
 EOF

Original file line number	Diff line number	Diff line change
`@@ -26,9 +26,12 @@ curl -sL https://registry.k6.io/registry.json \|`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`replace_extension_list_partial() {`
`29`		`-ed -s $1 <<EOF`
	`29`	`+local -r outfile="$1"`
	`30`	`+local -r infile="$2"`
	`31`	`+`
	`32`	`+ed -s "$outfile" <<EOF`
`30`	`33`	`/<div class=.nav-cards.>/+,/<.div>/-d`
`31`		`-/<div class=.nav-cards.>/ r $2`
	`34`	`+/<div class=.nav-cards.>/ r "$infile"`
`32`	`35`	`w`
`33`	`36`	`q`
`34`	`37`	`EOF`