Skip to content

Commit 63ba8be

Browse files
mdcruzka3de
authored andcommitted
update locator.click to use await keyword
1 parent 3d6de43 commit 63ba8be

File tree

6 files changed

+32
-35
lines changed

6 files changed

+32
-35
lines changed

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/04-element-handle.md

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -52,31 +52,29 @@ excerpt: "Browser module: ElementHandle Class"
5252
import { check } from 'k6';
5353
import { chromium } from 'k6/experimental/browser';
5454

55-
export default async function() {
55+
export default async function () {
5656
const browser = chromium.launch({
5757
headless: false,
58-
slowMo: '500ms' // slow down by 500ms
58+
slowMo: '500ms', // slow down by 500ms
5959
});
6060
const context = browser.newContext();
6161
const page = context.newPage();
6262

6363
// Goto front page, find login link and click it
6464
try {
6565
await page.goto('https://test.k6.io/', { waitUntil: 'networkidle' });
66-
await Promise.all([
67-
page.waitForNavigation(),
68-
page.locator('a[href="/my_messages.php"]').click(),
69-
]);
66+
const messagesLink = page.locator('a[href="/my_messages.php"]');
67+
68+
await Promise.all([page.waitForNavigation(), messagesLink.click()]);
7069
// Enter login credentials and login
7170
page.locator('input[name="login"]').type('admin');
7271
page.locator('input[name="password"]').type('123');
73-
74-
await Promise.all([
75-
page.waitForNavigation(),
76-
page.locator('input[type="submit"]').click(),
77-
]);
72+
73+
const submitButton = page.locator('input[type="submit"]');
74+
75+
await Promise.all([page.waitForNavigation(), submitButton.click()]);
7876
check(page, {
79-
'header': page.locator('h2').textContent() == 'Welcome, admin!',
77+
header: page.locator('h2').textContent() == 'Welcome, admin!',
8078
});
8179
} finally {
8280
page.close();

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/08 Locator/click--options--.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ import { chromium } from 'k6/experimental/browser';
4040
export default async function () {
4141
const browser = chromium.launch();
4242
const page = browser.newPage();
43-
43+
4444
await page.goto('https://test.k6.io/browser.php');
45-
const button = page.locator("#counter-button");
46-
button.click();
45+
const button = page.locator('#counter-button');
46+
await button.click();
4747
}
4848
```
4949

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/10-page.md

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ excerpt: "Browser module: Page Class"
7575
import { check } from 'k6';
7676
import { chromium } from 'k6/experimental/browser';
7777

78-
export default async function() {
78+
export default async function () {
7979
const browser = chromium.launch({
8080
headless: false,
8181
});
@@ -85,20 +85,18 @@ export default async function() {
8585
// Goto front page, find login link and click it
8686
try {
8787
await page.goto('https://test.k6.io/', { waitUntil: 'networkidle' });
88-
await Promise.all([
89-
page.waitForNavigation(),
90-
page.locator('a[href="/my_messages.php"]').click(),
91-
]);
88+
const messagesLink = page.locator('a[href="/my_messages.php"]');
89+
90+
await Promise.all([page.waitForNavigation(), messagesLink.click()]);
9291
// Enter login credentials and login
9392
page.locator('input[name="login"]').type('admin');
9493
page.locator('input[name="password"]').type('123');
95-
96-
await Promise.all([
97-
page.waitForNavigation(),
98-
page.locator('input[type="submit"]').click(),
99-
]);
94+
95+
const submitButton = page.locator('input[type="submit"]');
96+
97+
await Promise.all([page.waitForNavigation(), submitButton.click()]);
10098
check(page, {
101-
'header': page.locator('h2').textContent() == 'Welcome, admin!',
99+
header: page.locator('h2').textContent() == 'Welcome, admin!',
102100
});
103101
} finally {
104102
page.close();

src/data/markdown/translated-guides/en/03 Using k6 browser/01 Overview.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ The main use case for the browser module is to test performance on the browser l
2626

2727
```javascript
2828
import { chromium } from 'k6/experimental/browser';
29-
import { check } from 'k6'
29+
import { check } from 'k6';
3030

3131
export default async function () {
3232
const browser = chromium.launch({ headless: false });
@@ -38,13 +38,12 @@ export default async function () {
3838
page.locator('input[name="login"]').type('admin');
3939
page.locator('input[name="password"]').type('123');
4040

41-
await Promise.all([
42-
page.waitForNavigation(),
43-
page.locator('input[type="submit"]').click(),
44-
]);
41+
const submitButton = page.locator('input[type="submit"]');
42+
43+
await Promise.all([page.waitForNavigation(), submitButton.click()]);
4544

4645
check(page, {
47-
'header': page.locator('h2').textContent() == 'Welcome, admin!',
46+
header: page.locator('h2').textContent() == 'Welcome, admin!',
4847
});
4948
} finally {
5049
page.close();

src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,9 @@ export default async function () {
132132
page.locator('input[name="login"]').type('admin');
133133
page.locator('input[name="password"]').type('123');
134134

135-
await Promise.all([page.waitForNavigation(), page.locator('input[type="submit"]').click()]);
135+
const submitButton = page.locator('input[type="submit"]');
136+
137+
await Promise.all([page.waitForNavigation(), submitButton.click()]);
136138

137139
check(page, {
138140
header: page.locator('h2').textContent() == 'Welcome, admin!',

src/data/markdown/translated-guides/en/08 Testing Guides/03 Load testing websites.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,10 +200,10 @@ export default async function () {
200200
sleep(4);
201201

202202
// 02. View products
203-
const element = page.$(
203+
const element = page.locator(
204204
'a[class="woocommerce-LoopProduct-link woocommerce-loop-product__link"]'
205205
);
206-
element.click();
206+
await element.click();
207207
page.waitForSelector('button[name="add-to-cart"]');
208208
page.screenshot({ path: 'screenshots/02_view-product.png' });
209209

0 commit comments

Comments
 (0)