Merge pull request #1298 from grafana/feat/add-invalid-metric-names-insights

Add invalid metric names to performance insights

Author: ckbedwell

src/data/markdown/docs/03 cloud/02 Analyzing Results/02 Performance Insights.md

@@ -25,6 +25,7 @@ k6 categorizes performance insights into three sets:
 - [Too many metrics](#too-many-metrics)
 - [Too many time series](#too-many-time-series)
 - [Outdated k6 Release Used](#outdated-k6-release-used)
+- [Invalid metric names](#invalid-metric-names)
 - [High load generator CPU usage](#high-load-generator-cpu-usage)
 - [High load generator memory usage](#high-load-generator-memory-usage)
 
@@ -248,6 +249,17 @@ for (let id = 1; id <= 1000; id++) {
   - Update the k6 binary that your CI/CD pipeline uses to run tests.
   - If you're part of an organization or team, collectively decide on a version of k6 to use going forward for consistency and ease of comparison.
 
+### Invalid metric names
+
+_Identifier_: `best_practice_invalid_metric_names`
+
+- **Happens when**:
+  you tag your custom metrics with invalid names.
+- **Recommendations**:
+  - Ensure your custom metric names comply with OpenTelemetry and [Prometheus limitations](https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels). Such as:
+    - Only contain valid symbols of ASCII letters, numbers, or `_`.
+    - Metric names must not start with a number.
+
 ## Health alerts
 
 Health alerts happen when the load generator has high resource utilization.
@@ -367,6 +379,7 @@ For all insights and their identifiers, refer to the table below:
 | Too Many Metrics                 | `best_practice_too_many_metrics`         | `best_practice` |
 | Too Many Time Series             | `best_practice_too_many_time_series`     | `best_practice` |
 | Outdated k6 Release Used         | `best_practice_outdated_k6_release_used` | `best_practice` |
+| Invalid Metric Names             | `best_practice_invalid_metric_names    ` | `best_practice` |
 | High Load Generator CPU Usage    | `health_high_loadgen_cpu_usage`          | `health`        |
 | High Load Generator Memory Usage | `health_high_loadgen_mem_usage`          | `health`        |
 

src/data/markdown/translated-guides/en/02 Using k6/02 Metrics.md

@@ -107,17 +107,11 @@ In that output, all the metrics that start with `http`, `iteration`, and `vu` ar
 For details of all metrics, refer to the [Metrics reference](/using-k6/metrics/reference/).
 
 
-### Metric name restrictions
+## Metric name restrictions
 
-<Blockquote mod="warning" title="">
+Metric names must comply with OpenTelemetry and [Prometheus limitations](https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels).
 
-In the future, metrics names will be further limited to comply with OpenTelemetry and Prometheus limitations.
-
-That means metric names can be 1 to 63 symbols of ASCII letters, numbers, or  `_`. Metric names must not start with a number.
-
-</Blockquote>
-
-At the moment, a metric name can be 1 to 128 symbols of:
+That means they must not start with a number and a metric name can be 1 to 63 symbols of:
 1. any Unicode Letters
 2. any Unicode Number
-3. `.`, `_`, ` `, `!`, `?`. `/`, `#`, `(`. `)`, `<`, `>`, `%` and `-`
+3. `_` (an underscore)