Skip to content

Commit a905cec

Browse files
authored
Merge pull request #1153 from grafana/remove-networkidle
refactor: remove networkidle option on browser tests
2 parents a811b34 + 57ea63f commit a905cec

File tree

28 files changed

+34
-43
lines changed

28 files changed

+34
-43
lines changed

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export default async function () {
3535
const page = context.newPage();
3636

3737
try {
38-
await page.goto('https://test.k6.io/', { waitUntil: 'networkidle' })
38+
await page.goto('https://test.k6.io/')
3939
} finally {
4040
page.close();
4141
browser.close();

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/01 Browser class.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export default async function () {
3232
const page = context.newPage();
3333

3434
try {
35-
await page.goto('https://test.k6.io/', { waitUntil: 'networkidle' });
35+
await page.goto('https://test.k6.io/');
3636
} finally {
3737
page.close();
3838
browser.close();

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/01 Browser class/newcontext--options--.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export default async function () {
6969
const page = context.newPage();
7070

7171
try {
72-
await page.goto('https://test.k6.io/', { waitUntil: 'networkidle' });
72+
await page.goto('https://test.k6.io/');
7373
} finally {
7474
page.close();
7575
browser.close();

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/01 Browser class/newpage--options--.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export default async function () {
6767
});
6868

6969
try {
70-
await page.goto('https://test.k6.io/', { waitUntil: 'networkidle' });
70+
await page.goto('https://test.k6.io/');
7171
} finally {
7272
page.close();
7373
browser.close();

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/02 BrowserContext/newPage.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export default async function () {
2626
const page = context.newPage();
2727

2828
try {
29-
await page.goto('https://test.k6.io/browser.php', { waitUntil: 'networkidle' });
29+
await page.goto('https://test.k6.io/browser.php');
3030
} finally {
3131
page.close();
3232
browser.close();

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/02 BrowserContext/setDefaultNavigationTimeout.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export default async function () {
3131
context.setDefaultNavigationTimeout(1000); // 1s
3232

3333
try {
34-
await page.goto('https://httpbin.test.k6.io/delay/5', { waitUntil: 'networkidle' });
34+
await page.goto('https://httpbin.test.k6.io/delay/5');
3535
} finally {
3636
page.close();
3737
browser.close();

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/02 BrowserContext/setOffline.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,8 @@ export default async function () {
2626
const page = context.newPage();
2727

2828
try {
29-
await page
30-
.goto('https://test.k6.io/browser.php', {
31-
// Will not be able to load the page
32-
waitUntil: 'networkidle'
33-
});
29+
// Will not be able to load the page
30+
await page.goto('https://test.k6.io/browser.php');
3431
} finally {
3532
page.close();
3633
browser.close();

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/03 BrowserType.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export default async function () {
2727
const page = context.newPage();
2828

2929
try {
30-
await page.goto('https://test.k6.io/', { waitUntil: 'networkidle' });
30+
await page.goto('https://test.k6.io/');
3131
page.screenshot({ path: `example-chromium.png` });
3232
} finally {
3333
page.close();

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/03 BrowserType/connect--options--.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export default async function () {
3737
const page = context.newPage();
3838

3939
try {
40-
await page.goto('https://test.k6.io/', { waitUntil: 'networkidle' });
40+
await page.goto('https://test.k6.io/');
4141
page.screenshot({ path: `example-chromium.png` });
4242
} finally {
4343
page.close();

src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/03 BrowserType/launch--options--.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ export default async function () {
100100
const page = context.newPage();
101101

102102
try {
103-
await page.goto('http://whatsmyuseragent.org/', { waitUntil: 'networkidle' });
103+
await page.goto('http://whatsmyuseragent.org/');
104104
page.screenshot({ path: `example-chromium.png` });
105105
} finally {
106106
page.close();

0 commit comments

Comments
 (0)