Skip to content

Commit b04ff59

Browse files
Apply suggestions from code review
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
1 parent cb973dc commit b04ff59

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/data/markdown/docs/02 javascript api/07 k6-experimental/02 grpc/20 Client/20-Client-connect-connect-address-params.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ See [Client.close()](/javascript-api/k6-experimental/grpc/client/client-close) t
2222
| `ConnectParams.timeout` | string / number | Connection timeout to use. Default timeout is `"60s"`. <br/> The type can also be a number, in which case k6 interprets it as milliseconds, e.g., `60000` is equivalent to `"60s"`. |
2323
| `ConnectParams.maxReceiveSize` | number | Sets the maximum message size in bytes the client can receive. Defaults to 0. |
2424
| `ConnectParams.maxSendSize` | number | Sets the maximum message size in bytes the client can send. Defaults to 0. |
25-
| `ConnectParams.tls` (optional) | object | [TLS](#tls) | TLS settings of the connection. Defaults not defined. |
25+
| `ConnectParams.tls` (optional) | object | [TLS](#tls) settings of the connection. Defaults to `null`. |
2626

2727
## TLS
2828

29-
TLS settings of the connection, if not defined, the main TLS config from options will be used.
29+
TLS settings of the connection. If not defined, the main TLS config from options will be used.
3030

3131
| Name | Type | Description |
3232
|------|------|-------------|
@@ -69,7 +69,9 @@ export default () => {
6969
import grpc from 'k6/experimental/grpc';
7070
import { check } from 'k6';
7171

72-
// note: there are no such services
72+
// note: the services in this example don't exist. If you would like
73+
// to run this example, make sure to replace the URLs, and
74+
// the cacerts, cert, key, and password variables.
7375
const params = {
7476
'foo1.grpcbin.test.k6.io:9001': {
7577
plaintext: false,

src/data/markdown/docs/02 javascript api/11 k6-net-grpc/20 Client/20-Client-connect-connect-address-params.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ See [Client.close()](/javascript-api/k6-net-grpc/client/client-close) to close t
2222
| `ConnectParams.timeout` | string / number | Connection timeout to use. Default timeout is `"60s"`. <br/> The type can also be a number, in which case k6 interprets it as milliseconds, e.g., `60000` is equivalent to `"60s"`. |
2323
| `ConnectParams.maxReceiveSize` | number | Sets the maximum message size in bytes the client can receive. Defaults to 0. |
2424
| `ConnectParams.maxSendSize` | number | Sets the maximum message size in bytes the client can send. Defaults to 0. |
25-
| `ConnectParams.tls` (optional) | object | [TLS](#tls) | TLS settings of the connection. Defaults not defined. |
25+
| `ConnectParams.tls` (optional) | object | [TLS](#tls) settings of the connection. Defaults to `null`. |
2626

2727
## TLS
2828

29-
TLS settings of the connection, if not defined, the main TLS config from options will be used.
29+
TLS settings of the connection. If not defined, the main TLS config from options will be used.
3030

3131
| Name | Type | Description |
3232
|------|------|-------------|

0 commit comments

Comments
 (0)