metrics: Use the correct term for types #2019
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
requested review from
mstoykov and
joanlopez
and removed request for
a team
|
|
mstoykov
approved these changes
Aug 11, 2025
|
I should update the all the previous versions + next. I will do it asap tomorrow. |
codebien
force-pushed
the
fix-metric-typo
branch
from
0c60062 to
a10b6d8
Compare
codebien
changed the title
codebien
commented
Aug 12, 2025
There was a problem hiding this comment.
Reminder: Unexpected
mstoykov
reviewed
Aug 12, 2025
| @@ -7,7 +7,7 @@ weight: 72 | |||
|
|
|||
| # Rate | |||
|
|
|||
| _Rate_ is an object for representing a custom metric keeping track of the percentage of added values that are non-zero. It is one of the four [custom metrics](https://grafana.com/docs/k6/<K6_VERSION>/javascript-api/k6-metrics). | |||
| _Rate_ is an object for representing a custom metric keeping track of the percentage of added values that are non-zero. It is one of the four [metric types](https://grafana.com/docs/k5/<K6_VERSION>/javascript-api/k6-metrics). | |||
There was a problem hiding this comment.
are we downgrading k6 to k5 😱
|
As this is not relevant for the release, I set this back to a draft because it requires additional work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In principle k6 has metric types and users can create custom metrics with them. But the two definitions are not strictly the same.
Checklist
npm startcommand locally and verified that the changes look good.docs/sources/k6/nextfolder of the documentation.docs/sources/k6/v{most_recent_release}folder of the documentation.docs/sources/k6/nextfolder of the documentation.Related PR(s)/Issue(s)