Skip to content

k6-operator: add link to CRD reference doc #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2025

Conversation

yorugac
Copy link
Contributor

@yorugac yorugac commented Aug 8, 2025

What?

We decided to keep the machine-generated CRD reference in the k6-operator repo, as it's unclear how to move it to the k6-docs. But there must be at least a link to it from the official docs. Let's add it here.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/k6/next folder of the documentation.
  • I have reflected my changes in the docs/sources/k6/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).
  • I have made my changes in the docs/sources/k6/next folder of the documentation.

Related PR(s)/Issue(s)

Related past work:
grafana/k6-operator#352

Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a small suggestion, but LGTM!

@heitortsergent heitortsergent added the Area:operator k6-operator label Aug 14, 2025
Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, could we rename the file to "configure-testrun-crd.md"? This would affect the grafana/k6-operator#630 PR as well, but that would fit our style guide better.

I also left a comment to update the title and h1.

Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Copy link
Contributor

github-actions bot commented Aug 15, 2025

💻 Deploy preview deleted.

@yorugac yorugac force-pushed the chore/add-reference-to-crd-doc branch from 044ede1 to 522376b Compare August 15, 2025 08:28
@yorugac
Copy link
Contributor Author

yorugac commented Aug 15, 2025

All renamings done and local preview looks 👌 Thanks Heitor!

@yorugac yorugac merged commit d64a882 into main Aug 15, 2025
9 checks passed
@yorugac yorugac deleted the chore/add-reference-to-crd-doc branch August 15, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:operator k6-operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants