-
Notifications
You must be signed in to change notification settings - Fork 238
k6-operator: add link to CRD reference doc #2026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a small suggestion, but LGTM!
docs/sources/k6/next/set-up/set-up-distributed-k6/usage/configuring-testrun-crd.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/v1.0.x/set-up/set-up-distributed-k6/usage/configuring-testrun-crd.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/v1.1.x/set-up/set-up-distributed-k6/usage/configuring-testrun-crd.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, could we rename the file to "configure-testrun-crd.md"? This would affect the grafana/k6-operator#630 PR as well, but that would fit our style guide better.
I also left a comment to update the title and h1.
docs/sources/k6/next/set-up/set-up-distributed-k6/usage/configuring-testrun-crd.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/set-up/set-up-distributed-k6/usage/configuring-testrun-crd.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
💻 Deploy preview deleted. |
044ede1
to
522376b
Compare
All renamings done and local preview looks 👌 Thanks Heitor! |
What?
We decided to keep the machine-generated CRD reference in the k6-operator repo, as it's unclear how to move it to the k6-docs. But there must be at least a link to it from the official docs. Let's add it here.
Checklist
npm start
command locally and verified that the changes look good.docs/sources/k6/next
folder of the documentation.docs/sources/k6/v{most_recent_release}
folder of the documentation.docs/sources/k6/next
folder of the documentation.Related PR(s)/Issue(s)
Related past work:
grafana/k6-operator#352