HTTP status code evaluation from ops?

[Schachte]

First off, I'm happy I remembered this lib exists! Realized we hacked together a nice solution to an existing problem that is helping me out today here:
#57

So thank you for the continued support on this project.

Now this may be a dumb question, but I'm playing around with the SDK and realizing there is no way for me to get the status code from the operations I invoke, is this correct?

    const putResponse = await s3Client.putObject(bucket, objectKey, data, {
      contentType: 'application/octet-stream',
      contentLength: objectSize,
    });

    const getResponse = await s3Client.getObject(bucket, objectKey);

    check(getResponse, {
      'GET operation successful': (r) => r.status === 200,
    });
    
    if (getResponse.status !== 200) {
      result.error = 'GET operation failed';
      return result;
    }

Take this for example. putResponse is undefined. How would I accurately report on putObject failure counts if this is always undefined?

Is it just like this?

  check(putResponse, {
    'PUT operation successful': (r) => r === undefined, // No error means success
  });

I'd also like assurance that object corruption wasn't present in transit by comparing hashes (etag), which we typically get from putobject.

My current form is:

    const putResponse = await s3Client.putObject(bucket, objectKey, data, {
      contentType: 'application/octet-stream',
      contentLength: objectSize,
    });
    check(putResponse, {
      'PUT operation successful': (r) => r === undefined
    });

    const getResponse = await s3Client.getObject(bucket, objectKey);
    check(getResponse, {
      'GET operation successful': (r) => r.key === objectKey && r.size === objectSize,
    });
    
    const deleteResponse = await s3Client.deleteObject(bucket, objectKey);
    check(deleteResponse, {
      'DELETE operation successful': (r) => r === undefined,
    });

[mstoykov]

Thank you for reporting this @Schachte , sorry for the slow reply 🙇

It seems that nothing in the s3 library is returning anything as result - it returns Promise<void>. This likely shouldn't be the case and they should return some response, I am not certain they should return just the normal http.Response or should it be something more specific.

cc @oleiade for any context on why it doesn't return anything.

[oleiade]

Hi @Schachte 👋🏻

First and foremost, apologies for coming back to this so late 🙇🏻

I have started a draft PR #123 to try and tackle your need. It introduces a S3UploadObject type, and makes sure the putObject operation does return that type. The type is based on the API definition, but as the PR is a draft, and I'm not a heavy user of S3 myself, I expect you might have feedback, or need additional features.

Please feel free to go ahead and review/offer feedback on the PR 🙇🏻

[Schachte]

Thank you!!