Skip to content

Commit cca9744

Browse files
authored
internal: fix macos build action (#705)
1 parent eaabaf0 commit cca9744

File tree

2 files changed

+42
-10
lines changed

2 files changed

+42
-10
lines changed

.github/workflows/release-test-version.yml

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
strategy:
1717
fail-fast: false
1818
matrix:
19-
platform: [macos-latest, windows-latest, ubuntu-latest]
19+
platform: [macos-latest, macos-13, windows-latest, ubuntu-latest]
2020

2121
runs-on: ${{ matrix.platform }}
2222
steps:
@@ -65,8 +65,8 @@ jobs:
6565
env:
6666
WINDOWS_CERTIFICATE: ${{ secrets.WINDOWS_CERTIFICATE }}
6767

68-
- name: publish macOS
69-
if: startsWith(matrix.platform, 'macos-')
68+
- name: publish macOS arm64
69+
if: startsWith(matrix.platform, 'macos-latest')
7070
env:
7171
NODE_OPTIONS: '--max_old_space_size=8192'
7272
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -81,10 +81,26 @@ jobs:
8181
SENTRY_ORG: ${{ vars.SENTRY_ORG }}
8282
SENTRY_PROJECT: ${{ vars.SENTRY_PROJECT }}
8383
run: |
84-
# on macos we also build the x64 app separately
85-
npm run publish -- --arch=x64
8684
npm run publish
8785
86+
- name: publish macOS x86_64
87+
if: startsWith(matrix.platform, 'macos-13')
88+
env:
89+
NODE_OPTIONS: '--max_old_space_size=8192'
90+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
91+
# notarization
92+
APPLE_API_KEY_ID: ${{ secrets.APPLE_API_KEY_ID }}
93+
APPLE_API_ISSUER: ${{ secrets.APPLE_API_ISSUER }}
94+
APPLE_API_KEY: ./apple_api_key.p8
95+
# sentry integration
96+
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
97+
# sentry vite plugin integration during build
98+
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
99+
SENTRY_ORG: ${{ vars.SENTRY_ORG }}
100+
SENTRY_PROJECT: ${{ vars.SENTRY_PROJECT }}
101+
run: |
102+
npm run publish -- --arch=x64
103+
88104
- name: publish Windows
89105
if: startsWith(matrix.platform, 'windows-')
90106
env:

.github/workflows/release.yml

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
strategy:
1111
fail-fast: false
1212
matrix:
13-
platform: [macos-latest, windows-latest, ubuntu-latest]
13+
platform: [macos-latest, macos-13, windows-latest, ubuntu-latest]
1414

1515
runs-on: ${{ matrix.platform }}
1616
steps:
@@ -54,8 +54,8 @@ jobs:
5454
env:
5555
WINDOWS_CERTIFICATE: ${{ secrets.WINDOWS_CERTIFICATE }}
5656

57-
- name: publish macOS
58-
if: startsWith(matrix.platform, 'macos-')
57+
- name: publish macOS arm64
58+
if: startsWith(matrix.platform, 'macos-latest')
5959
env:
6060
NODE_OPTIONS: '--max_old_space_size=8192'
6161
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -70,10 +70,26 @@ jobs:
7070
SENTRY_ORG: ${{ vars.SENTRY_ORG }}
7171
SENTRY_PROJECT: ${{ vars.SENTRY_PROJECT }}
7272
run: |
73-
# on macos we also build the x64 app separately
74-
npm run publish -- --arch=x64
7573
npm run publish
7674
75+
- name: publish macOS x86_64
76+
if: startsWith(matrix.platform, 'macos-13')
77+
env:
78+
NODE_OPTIONS: '--max_old_space_size=8192'
79+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
80+
# notarization
81+
APPLE_API_KEY_ID: ${{ secrets.APPLE_API_KEY_ID }}
82+
APPLE_API_ISSUER: ${{ secrets.APPLE_API_ISSUER }}
83+
APPLE_API_KEY: ./apple_api_key.p8
84+
# sentry integration
85+
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
86+
# sentry vite plugin integration during build
87+
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
88+
SENTRY_ORG: ${{ vars.SENTRY_ORG }}
89+
SENTRY_PROJECT: ${{ vars.SENTRY_PROJECT }}
90+
run: |
91+
npm run publish -- --arch=x64
92+
7793
- name: publish Windows
7894
if: startsWith(matrix.platform, 'windows-')
7995
env:

0 commit comments

Comments
 (0)