Skip to content

Commit ae8e728

Browse files
chore(deps): update dependency tar to v7.5.8 [security] (#1753)
* chore(deps): update dependency tar to v7.5.8 [security] | datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | tar | 7.5.7 | 7.5.8 | Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com> * chore(ci): fix flaky e2e tests * chore(ci): revert changes to exploreServicesBreakDown --------- Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com> Co-authored-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com> Co-authored-by: L2D2Grafana <liza.detrick@grafana.com>
1 parent 0be14ed commit ae8e728

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@
141141
"uuid": "^10.0.0",
142142
"qs": "6.14.2",
143143
"strip-ansi": "6.0.1",
144-
"tar": "7.5.7",
144+
"tar": "7.5.8",
145145
"js-yaml": "4.1.1"
146146
},
147147
"packageManager": "yarn@4.5.0"

tests/savedSearches.spec.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,9 @@ test.describe('saved searches', () => {
9999

100100
// Step 10: Verify we're navigated to the service details page with the correct filter
101101
await expect(page.getByTestId(testIds.exploreServiceDetails.tabLogs)).toBeVisible();
102-
// Multiple "Edit filter with key" chips exist; assert the one for our service is visible
103-
await expect(
104-
page.getByRole('button', { name: /Edit filter with key service_name/ }).filter({ hasText: 'tempo-ingester' })
105-
).toBeVisible();
102+
// Use getByLabel which matches Grafana's ad-hoc filter chip (used in embed.spec, exploreServices.spec)
103+
await expect(page.getByLabel('Edit filter with key service_name')).toBeVisible();
104+
await expect(page.getByLabel('Edit filter with key service_name')).toContainText('tempo-ingester');
106105
});
107106

108107
test('should show empty state when no saved searches exist', async ({ page }) => {
@@ -155,8 +154,9 @@ test.describe('saved searches', () => {
155154
await unlockButton.click();
156155
}
157156

158-
// Click the delete button
159-
const deleteButton = page.getByRole('button', { name: 'Remove' });
157+
// Click the delete button - scope to modal to avoid matching favorite "Remove X from favorites" button
158+
const loadSearchModal = page.getByRole('dialog', { name: /Load a previously saved search/ });
159+
const deleteButton = loadSearchModal.getByRole('button', { name: 'Remove' });
160160
await expect(deleteButton).toBeVisible();
161161
await deleteButton.click();
162162

@@ -244,8 +244,8 @@ test.describe('saved searches', () => {
244244

245245
// Verify we're back on the breakdown view with correct filter
246246
await expect(page.getByTestId(testIds.exploreServiceDetails.tabLogs)).toBeVisible();
247-
await expect(
248-
page.getByRole('button', { name: /Edit filter with key service_name/ }).filter({ hasText: 'tempo-ingester' })
249-
).toBeVisible();
247+
// Use getByLabel which matches Grafana's ad-hoc filter chip
248+
await expect(page.getByLabel('Edit filter with key service_name')).toBeVisible();
249+
await expect(page.getByLabel('Edit filter with key service_name')).toContainText('tempo-ingester');
250250
});
251251
});

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14346,16 +14346,16 @@ __metadata:
1434614346
languageName: node
1434714347
linkType: hard
1434814348

14349-
"tar@npm:7.5.7":
14350-
version: 7.5.7
14351-
resolution: "tar@npm:7.5.7"
14349+
"tar@npm:7.5.8":
14350+
version: 7.5.8
14351+
resolution: "tar@npm:7.5.8"
1435214352
dependencies:
1435314353
"@isaacs/fs-minipass": "npm:^4.0.0"
1435414354
chownr: "npm:^3.0.0"
1435514355
minipass: "npm:^7.1.2"
1435614356
minizlib: "npm:^3.1.0"
1435714357
yallist: "npm:^5.0.0"
14358-
checksum: 10c0/51f261afc437e1112c3e7919478d6176ea83f7f7727864d8c2cce10f0b03a631d1911644a567348c3063c45abdae39718ba97abb073d22aa3538b9a53ae1e31c
14358+
checksum: 10c0/8569db1b49f5d72084cbdcad9d2b39fcc115993186455aa052c1da0a2739b20e2d94af6a23609fc25d3ae63c9fed8b159f3b1d16b699e9ef25e3b8464603d153
1435914359
languageName: node
1436014360
linkType: hard
1436114361

0 commit comments

Comments
 (0)