Open
Conversation
Signed-off-by: TheRealNoob <mike1118@live.com>
Signed-off-by: TheRealNoob <mike1118@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
expands functionality of
extraObjectsto support list and map structures. Copied this feature from kube-prometheus-stack.Which issue(s) this PR fixes or relates to
didn't open one
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.Note
Low Risk
Helm templating change scoped to
extraObjectsrendering with added CI coverage; low blast radius but could affect users relying on edge-case formatting/whitespace in rendered manifests.Overview
Adds support for defining
extraObjectsas either a list or a map in themimir-distributedHelm chart; when a map is provided, the template now ignores keys and renders the values as manifests.Updates documentation/comments and changelog accordingly, and adds an offline CI fixture plus a generated golden-output test to validate the map-based
extraObjectsrendering.Written by Cursor Bugbot for commit 0ed0381. This will update automatically on new commits. Configure here.