Skip to content

Comments

feat(helm): enhance extraObjects#14193

Open
TheRealNoob wants to merge 2 commits intografana:mainfrom
TheRealNoob:extraobjects
Open

feat(helm): enhance extraObjects#14193
TheRealNoob wants to merge 2 commits intografana:mainfrom
TheRealNoob:extraobjects

Conversation

@TheRealNoob
Copy link
Contributor

@TheRealNoob TheRealNoob commented Jan 28, 2026

What this PR does

expands functionality of extraObjects to support list and map structures. Copied this feature from kube-prometheus-stack.

Which issue(s) this PR fixes or relates to

didn't open one

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]. If changelog entry is not needed, please add the changelog-not-needed label to the PR.
  • about-versioning.md updated with experimental features.

Note

Low Risk
Helm templating change scoped to extraObjects rendering with added CI coverage; low blast radius but could affect users relying on edge-case formatting/whitespace in rendered manifests.

Overview
Adds support for defining extraObjects as either a list or a map in the mimir-distributed Helm chart; when a map is provided, the template now ignores keys and renders the values as manifests.

Updates documentation/comments and changelog accordingly, and adds an offline CI fixture plus a generated golden-output test to validate the map-based extraObjects rendering.

Written by Cursor Bugbot for commit 0ed0381. This will update automatically on new commits. Configure here.

Signed-off-by: TheRealNoob <mike1118@live.com>
@TheRealNoob TheRealNoob requested a review from a team as a code owner January 28, 2026 21:29
Signed-off-by: TheRealNoob <mike1118@live.com>
@TheRealNoob TheRealNoob changed the title exhance extraObjects feat(mimir): exhance extraObjects Jan 28, 2026
@TheRealNoob TheRealNoob changed the title feat(mimir): exhance extraObjects feat(mimir): enhance extraObjects Jan 29, 2026
@TheRealNoob TheRealNoob changed the title feat(mimir): enhance extraObjects feat(helm): enhance extraObjects Jan 29, 2026
Copy link
Contributor

@tacole02 tacole02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants