fix(pprof): do not use - in sample type names (#41)

Author: korniltsev

profiler/src/ProfilerEngine/Datadog.Profiler.Native/AllocationsProvider.cpp

@@ -21,8 +21,8 @@
 
 std::vector<SampleValueType> AllocationsProvider::SampleTypeDefinitions(
     {
-        {"alloc-samples", "count"},
-        {"alloc-size", "bytes"}
+        {"alloc_samples", "count"},
+        {"alloc_size", "bytes"}
     });
 
 

profiler/src/ProfilerEngine/Datadog.Profiler.Native/ContentionProvider.cpp

@@ -15,8 +15,8 @@
 
 std::vector<SampleValueType> ContentionProvider::SampleTypeDefinitions(
     {
-        {"lock-count", "count"},
-        {"lock-time", "nanoseconds"}
+        {"lock_count", "count"},
+        {"lock_time", "nanoseconds"}
     });
 
 

profiler/src/ProfilerEngine/Datadog.Profiler.Native/LiveObjectsProvider.cpp

@@ -12,8 +12,8 @@
 
 std::vector<SampleValueType> LiveObjectsProvider::SampleTypeDefinitions(
 {
-    {"inuse-objects", "count"},
-    {"inuse-space", "bytes"}
+    {"inuse_objects", "count"},
+    {"inuse_space", "bytes"}
 });
 
 const uint32_t MAX_LIVE_OBJECTS = 1024;

profiler/src/ProfilerEngine/Datadog.Profiler.Native/PyroscopePprofSink.cpp

@@ -100,11 +100,11 @@ void PyroscopePprofSink::upload(Pprof pprof, ProfileTime& startTime, ProfileTime
     data.emplace_back(httplib::MultipartFormData{
         .name = "sample_type_config",
         .content = "{\n"
-                   "  \"alloc-samples\": {\n"
+                   "  \"alloc_samples\": {\n"
                    "    \"units\": \"objects\",\n"
                    "    \"display-name\": \"alloc_objects\"\n"
                    "  },\n"
-                   "  \"alloc-size\": {\n"
+                   "  \"alloc_size\": {\n"
                    "    \"units\": \"bytes\",\n"
                    "    \"display-name\": \"alloc_space\"\n"
                    "  },\n"
@@ -116,24 +116,24 @@ void PyroscopePprofSink::upload(Pprof pprof, ProfileTime& startTime, ProfileTime
                    "    \"units\": \"exceptions\",\n"
                    "    \"display-name\": \"exceptions\"\n"
                    "  },\n"
-                   "  \"lock-count\": {\n"
+                   "  \"lock_count\": {\n"
                    "    \"units\": \"lock_samples\",\n"
                    "    \"display-name\": \"mutex_count\"\n"
                    "  },\n"
-                   "  \"lock-time\": {\n"
+                   "  \"lock_time\": {\n"
                    "    \"units\": \"lock_nanoseconds\",\n"
                    "    \"display-name\": \"mutex_duration\"\n"
                    "  },\n"
                    "  \"wall\": {\n"
                    "    \"units\": \"samples\",\n"
                    "    \"sampled\": true\n"
                    "  },\n"
-                   "  \"inuse-objects\": {\n"
+                   "  \"inuse_objects\": {\n"
                    "    \"units\": \"objects\",\n"
                    "    \"display-name\": \"inuse_objects\",\n"
                    "    \"aggregation\": \"average\"\n"
                    "  },\n"
-                   "  \"inuse-space\": {\n"
+                   "  \"inuse_space\": {\n"
                    "    \"units\": \"bytes\",\n"
                    "    \"display-name\": \"inuse_space\",\n"
                    "    \"aggregation\": \"average\"\n"