fix: apply suggestions from review #88 (#90)

Author: korniltsev

profiler/src/ProfilerEngine/Datadog.Profiler.Native/CorProfilerCallback.cpp

@@ -2075,7 +2075,7 @@ void CorProfilerCallback::SetStackSamplerEnabled(bool enabled)
     }
     else
     {
-        _pStackSamplerLoopManager->Stop2(ServiceBase::State::Init);
+        _pStackSamplerLoopManager->StopWithState(ServiceBase::State::Init);
     }
 }
 

profiler/src/ProfilerEngine/Datadog.Profiler.Native/ServiceBase.cpp

@@ -57,10 +57,10 @@ bool ServiceBase::Start()
 
 bool ServiceBase::Stop()
 {
-    return Stop2(State::Stopped);
+    return StopWithState(State::Stopped);
 }
 
-bool ServiceBase::Stop2(State stoppedState)
+bool ServiceBase::StopWithState(State stoppedState)
 {
     if (stoppedState != State::Stopped && stoppedState != State::Init)
     {

profiler/src/ProfilerEngine/Datadog.Profiler.Native/ServiceBase.h

@@ -24,7 +24,7 @@ class ServiceBase : public IService
     bool Stop() final override;
 
     // Like Stop, but allows to specify stopped state - either Stopped or Init. Init allows the service to be restarted.
-    bool Stop2(State stoppedState); // todo better name
+    bool StopWithState(State stoppedState);
 
 protected:
     virtual bool StartImpl() = 0;