Skip to content

Commit a6714ed

Browse files
authored
Logging cleanup (#44)
* do not log dlopen errors * bump version
1 parent b632188 commit a6714ed

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

Pyroscope/Pyroscope/Pyroscope.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
<ImplicitUsings>enable</ImplicitUsings>
66
<Nullable>enable</Nullable>
77
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
8-
<PackageVersion>0.8.11</PackageVersion>
9-
<AssemblyVersion>0.8.11</AssemblyVersion>
10-
<FileVersion>0.8.11</FileVersion>
8+
<PackageVersion>0.8.12</PackageVersion>
9+
<AssemblyVersion>0.8.12</AssemblyVersion>
10+
<FileVersion>0.8.12</FileVersion>
1111
<LangVersion>10</LangVersion>
1212
</PropertyGroup>
1313

profiler/src/ProfilerEngine/Datadog.Profiler.Native/PyroscopePprofSink.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#include "httplib.h"
1111
#include "url.hpp"
1212

13-
#define PYROSCOPE_SPY_VERSION "0.8.11"
13+
#define PYROSCOPE_SPY_VERSION "0.8.12"
1414

1515
class PyroscopePprofSink : public PProfExportSink
1616
{

profiler/src/ProfilerEngine/Datadog.Profiler.Native/RuntimeIdStore.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ const char* RuntimeIdStore::GetId(AppDomainID appDomainId)
103103

104104
void* RuntimeIdStore::LoadDynamicLibrary(std::string filePath)
105105
{
106-
Log::Debug("LoadDynamicLibrary: ", filePath);
107106

108107
#if _WINDOWS
109108
HMODULE dynLibPtr = LoadLibrary(::shared::ToWSTRING(filePath).c_str());
@@ -127,7 +126,6 @@ void* RuntimeIdStore::LoadDynamicLibrary(std::string filePath)
127126
if (dynLibPtr == nullptr)
128127
{
129128
char* errorMessage = dlerror();
130-
Log::Warn("LoadDynamicLibrary: Error loading dynamic library '", filePath, "': ", errorMessage);
131129
}
132130
return dynLibPtr;
133131
#endif

0 commit comments

Comments
 (0)