Skip to content

Commit eef5409

Browse files
authored
chore(pyroscope): remove some labels (#81)
1 parent 0a7a592 commit eef5409

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

profiler/src/ProfilerEngine/Datadog.Profiler.Native/RawContentionSample.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,16 +47,8 @@ class RawContentionSample : public RawSample
4747
auto contentionCountIndex = valueOffsets[0];
4848
auto contentionDurationIndex = valueOffsets[1];
4949

50-
//sample->AddLabel(Label{BucketLabelName, std::move(Bucket)});
5150
sample->AddValue(1, contentionCountIndex);
52-
sample->AddNumericLabel(NumericLabel{RawCountLabelName, 1});
53-
sample->AddNumericLabel(NumericLabel{RawDurationLabelName, static_cast<uint64_t>(ContentionDuration)});
5451
sample->AddValue(static_cast<std::int64_t>(ContentionDuration), contentionDurationIndex);
55-
if (BlockingThreadId != 0)
56-
{
57-
sample->AddNumericLabel(NumericLabel{BlockingThreadIdLabelName, BlockingThreadId});
58-
sample->AddLabel(Label{BlockingThreadNameLabelName, shared::ToString(BlockingThreadName)});
59-
}
6052
}
6153

6254
double ContentionDuration;

profiler/src/ProfilerEngine/Datadog.Profiler.Native/Sample.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ class Sample
7575
template<typename T>
7676
void AddNumericLabel(T&& label)
7777
{
78-
_numericLabels.push_back(std::forward<T>(label));
78+
// pyroscope does not use numeric labels
7979
}
8080

8181
template<typename T>

0 commit comments

Comments
 (0)