chore: no printing in tests (#151)

Author: korniltsev

godeltaprof/compat/generics_go21_test.go

@@ -234,7 +234,8 @@ func TestGenericsHashKeyInPprofBuilder(t *testing.T) {
 		runtime.MemProfileRate = previousRate
 	}()
 	for _, sz := range []int{128, 256} {
-		_ = genericAllocFunc[uint32](sz / 4)
+		it := genericAllocFunc[uint32](sz / 4)
+		escape(it)
 	}
 	for _, sz := range []int{32, 64} {
 		it := genericAllocFunc[uint64](sz / 8)
@@ -352,9 +353,13 @@ func WriteHeapProfile(w io.Writer) error {
 	return dh.Profile(w)
 }
 
+var blackhole []any
+
 // make sure a is on the heap
 // https://go-review.googlesource.com/c/go/+/649035
 // https://go-review.googlesource.com/c/go/+/653856
 func escape(a any) {
-	fmt.Println(a)
+	blackhole = append(blackhole, a)
+	blackhole[0] = nil
+	blackhole = blackhole[:0]
 }

godeltaprof/compat/reject_order_test.go

@@ -70,13 +70,11 @@ func TestMutexReject(t *testing.T) {
 			p1 := bytes.NewBuffer(nil)
 			err := PrintCountCycleProfile(h.dp, h.opt, p1, scaler, fs)
 			assert.NoError(t, err)
-			p1Size := p1.Len()
 			profile, err := gprofile.Parse(p1)
 			require.NoError(t, err)
 			ls := stackCollapseProfile(t, profile)
 			assert.Len(t, ls, 512)
 			assert.Len(t, profile.Location, 141)
-			t.Log("p1 size", p1Size)
 
 			p2 := bytes.NewBuffer(nil)
 			err = PrintCountCycleProfile(h.dp, h.opt, p2, scaler, fs)
@@ -88,7 +86,6 @@ func TestMutexReject(t *testing.T) {
 			ls = stackCollapseProfile(t, profile)
 			assert.Len(t, ls, 0)
 			assert.Len(t, profile.Location, 0)
-			t.Log("p2 size", p2Size)
 		})
 	}
 }

godeltaprof/compat/scale_test.go

@@ -2,7 +2,6 @@ package compat
 
 import (
 	"bytes"
-	"fmt"
 	"io"
 	"math"
 	"runtime"
@@ -61,9 +60,6 @@ func TestScaleMutex(t *testing.T) {
 	my := findStack(t, res, "github.com/grafana/pyroscope-go/godeltaprof/compat.TestScaleMutex")
 	require.NotNil(t, my)
 
-	fmt.Println(my.value[0], my.value[1])
-	fmt.Println(expectedCount, expectedTime)
-
 	assert.Less(t, math.Abs(float64(my.value[0])-float64(expectedCount)), e*float64(expectedCount))
 	assert.Less(t, math.Abs(float64(my.value[1])-float64(expectedTime)), e*float64(expectedTime))
 }
@@ -109,9 +105,6 @@ func TestScaleBlock(t *testing.T) {
 	my := findStack(t, res, "github.com/grafana/pyroscope-go/godeltaprof/compat.TestScaleBlock")
 	require.NotNil(t, my)
 
-	fmt.Println(my.value[0], my.value[1])
-	fmt.Println(expectedCount, expectedTime)
-
 	assert.Less(t, math.Abs(float64(my.value[0])-float64(expectedCount)), 0.4*float64(expectedCount))
 	assert.Less(t, math.Abs(float64(my.value[1])-float64(expectedTime)), 0.4*float64(expectedTime))
 }
@@ -166,8 +159,6 @@ func TestScaleHeap(t *testing.T) {
 	my := findStack(t, res, "github.com/grafana/pyroscope-go/godeltaprof/compat.TestScaleHeap;github.com/grafana/pyroscope-go/godeltaprof/compat.appendBuf")
 	require.NotNil(t, my)
 
-	fmt.Println(my.value)
-	fmt.Println(expected)
 	for i := range my.value {
 		assert.Less(t, math.Abs(float64(my.value[i])-float64(expected[i])), 0.1*float64(expected[i]))
 	}

godeltaprof/compat/stackcollapse.go

@@ -2,7 +2,6 @@ package compat
 
 import (
 	"bytes"
-	"fmt"
 	"io"
 	"reflect"
 	"regexp"
@@ -46,7 +45,6 @@ func expectNoStackFrames(t *testing.T, buffer *bytes.Buffer, sfPattern string) {
 }
 
 func expectStackFrames(t *testing.T, buffer *bytes.Buffer, sfPattern string, values ...int64) {
-	fmt.Printf("expectStackFrames: %s %+v\n", sfPattern, values)
 	profile, err := gprofile.ParseData(buffer.Bytes())
 	require.NoError(t, err)
 	line := findStack(t, stackCollapseProfile(t, profile), sfPattern)